HTTPCORE-778: URIBuilder to not encode sub-delims in URI fragment component for consistency with query component encoding

Author: ok2c

httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java

@@ -338,7 +338,7 @@ private String buildString() {
                 if (InetAddressUtils.isIPv6(this.host)) {
                     sb.append("[").append(this.host).append("]");
                 } else {
-                    sb.append(PercentCodec.encode(this.host, this.charset));
+                    PercentCodec.encode(sb, this.host, this.charset);
                 }
                 if (this.port >= 0) {
                     sb.append(":").append(this.port);
@@ -369,7 +369,7 @@ private String buildString() {
             sb.append("#").append(this.encodedFragment);
         } else if (this.fragment != null) {
             sb.append("#");
-            PercentCodec.encode(sb, this.fragment, this.charset);
+            PercentCodec.encode(sb, this.fragment, this.charset, PercentCodec.URIC, false);
         }
         return sb.toString();
     }

httpcore5/src/test/java/org/apache/hc/core5/net/TestURIBuilder.java

@@ -473,6 +473,17 @@ void testPathEncoding() throws Exception {
         Assertions.assertEquals(uri1, uri2);
     }
 
+    @Test
+    void testFragmentEncoding() throws Exception {
+        final URI uri1 = new URI("https://somehost.com#some%20fragment%20with%20all%20sorts%20of%20$tuff%20in%20it!!!");
+        final URI uri2 = new URIBuilder()
+                .setScheme("https")
+                .setHost("somehost.com")
+                .setFragment("some fragment with all sorts of $tuff in it!!!")
+                .build();
+        Assertions.assertEquals(uri1, uri2);
+    }
+
     @Test
     void testAgainstURI() throws Exception {
         // Check that the URI generated by URI builder agrees with that generated by using URI directly