Minor code cleanup

Author: strangelookingnerd

httpcore5-testing/src/test/java/org/apache/hc/core5/testing/compatibility/http2/H2CompatibilityTest.java

@@ -96,7 +96,7 @@ public static void main(final String... args) throws Exception {
         }
     }
 
-    H2CompatibilityTest() throws Exception {
+    H2CompatibilityTest() {
         this.client = H2RequesterBootstrap.bootstrap()
                 .setIOReactorConfig(IOReactorConfig.custom()
                         .setSoTimeout(TIMEOUT)
@@ -113,11 +113,11 @@ public static void main(final String... args) throws Exception {
                 .create();
     }
 
-    void start() throws Exception {
+    void start() {
         client.start();
     }
 
-    void shutdown() throws Exception {
+    void shutdown() {
         client.close(CloseMode.GRACEFUL);
     }
 

httpcore5-testing/src/test/java/org/apache/hc/core5/testing/extension/nio/H2AsyncServerResource.java

@@ -27,7 +27,6 @@
 
 package org.apache.hc.core5.testing.extension.nio;
 
-import java.io.IOException;
 import java.util.function.Consumer;
 
 import org.apache.hc.core5.http.impl.bootstrap.HttpAsyncServer;
@@ -85,7 +84,7 @@ public void afterEach(final ExtensionContext extensionContext) throws Exception
         }
     }
 
-    public HttpAsyncServer start() throws IOException {
+    public HttpAsyncServer start() {
         Assertions.assertNotNull(server);
         server.start();
         return server;

httpcore5-testing/src/test/java/org/apache/hc/core5/testing/extension/nio/HttpAsyncServerResource.java

@@ -27,7 +27,6 @@
 
 package org.apache.hc.core5.testing.extension.nio;
 
-import java.io.IOException;
 import java.util.function.Consumer;
 
 import org.apache.hc.core5.http.impl.bootstrap.AsyncServerBootstrap;
@@ -83,7 +82,7 @@ public void afterEach(final ExtensionContext extensionContext) throws Exception
         }
     }
 
-    public HttpAsyncServer start() throws IOException {
+    public HttpAsyncServer start() {
         Assertions.assertNotNull(server);
         server.start();
         return server;

httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/AsyncServerBootstrapFilterTest.java

@@ -105,7 +105,7 @@ public void pushPromise(
                     })));
 
     @RegisterExtension
-    private final HttpAsyncRequesterResource clientResource = new HttpAsyncRequesterResource((bootstrap) -> bootstrap
+    private final HttpAsyncRequesterResource clientResource = new HttpAsyncRequesterResource(bootstrap -> bootstrap
             .setIOReactorConfig(IOReactorConfig.custom()
                     .setSoTimeout(TIMEOUT)
                     .build()));

httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ConnPoolTest.java

@@ -28,7 +28,6 @@
 package org.apache.hc.core5.testing.nio;
 
 import java.net.InetSocketAddress;
-import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.Future;
 import java.util.concurrent.atomic.AtomicLong;
@@ -155,7 +154,7 @@ void testManyGetSessionFailures() throws Exception {
         final H2MultiplexingRequester requester = clientResource.start();
         final H2ConnPool connPool = requester.getConnPool();
         final CountDownLatch latch = new CountDownLatch(n);
-        final ConcurrentLinkedQueue<Long> concurrentConnections = new ConcurrentLinkedQueue<>();
+
         for (int i = 0; i < n; i++) {
             connPool.getSession(target, TIMEOUT, new FutureCallback<IOSession>() {
 

httpcore5-testing/src/test/java/org/apache/hc/core5/testing/nio/H2ServerBootstrapFiltersTest.java

@@ -70,7 +70,7 @@ abstract class H2ServerBootstrapFiltersTest {
     private static final Timeout TIMEOUT = Timeout.ofMinutes(1);
 
     @RegisterExtension
-    private final H2AsyncServerResource serverResource = new H2AsyncServerResource((bootstrap) -> bootstrap
+    private final H2AsyncServerResource serverResource = new H2AsyncServerResource(bootstrap -> bootstrap
             .setVersionPolicy(HttpVersionPolicy.NEGOTIATE)
             .setIOReactorConfig(
                     IOReactorConfig.custom()

httpcore5/src/test/java/org/apache/hc/core5/http/message/TestHeaderElement.java

@@ -41,10 +41,8 @@ class TestHeaderElement {
     @Test
     void testConstructor3() {
         final HeaderElement element = new BasicHeaderElement("name", "value",
-                new NameValuePair[] {
-                    new BasicNameValuePair("param1", "value1"),
-                    new BasicNameValuePair("param2", "value2")
-                } );
+                new BasicNameValuePair("param1", "value1"),
+                new BasicNameValuePair("param2", "value2"));
         Assertions.assertEquals("name", element.getName());
         Assertions.assertEquals("value", element.getValue());
         Assertions.assertEquals(2, element.getParameters().length);
@@ -82,10 +80,8 @@ void testParamByName() {
     @Test
     void testToString() {
         final BasicHeaderElement element = new BasicHeaderElement("name", "value",
-                new NameValuePair[] {
-                        new BasicNameValuePair("param1", "value1"),
-                        new BasicNameValuePair("param2", "value2")
-                } );
+                new BasicNameValuePair("param1", "value1"),
+                new BasicNameValuePair("param2", "value2"));
         Assertions.assertEquals("name=value; param1=value1; param2=value2", element.toString());
     }
 

httpcore5/src/test/java/org/apache/hc/core5/http/protocol/TestStandardInterceptors.java

@@ -986,7 +986,7 @@ void testRequestHttpHostHeaderNoPort() throws Exception {
     }
 
     @Test
-    void testRequestHttp11HostHeaderPresent() {
+    void testRequestHttp11HostHeaderPresent() throws Exception {
         final HttpCoreContext context = HttpCoreContext.create();
         final BasicClassicHttpRequest request = new BasicClassicHttpRequest(Method.GET, "/");
         request.setHeader(HttpHeaders.HOST, "blah");