Skip to content

Commit 391445d

Browse files
committed
Revert r1914045, since the new -o option duplicates the -B option.
Thread: https://lists.apache.org/thread/w26fk0m0r52lys1wxwn11b862vc1y631 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1927630 13f79535-47bb-0310-9956-ffa450edef68
1 parent f40ebca commit 391445d

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

docs/man/ab.1

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,6 @@ String to use as attributes for \fB<table>\fR\&. Attributes are inserted \fB<tab
136136
\fB-X \fIproxy\fR[:\fIport\fR]\fR
137137
Use a proxy server for the requests\&.
138138
.TP
139-
\fB-o \fIsrc_address\fR\fR
140-
Set the local source address\&.
141-
.TP
142139
\fB-y \fI<tr>-attributes\fR\fR
143140
String to use as attributes for \fB<tr>\fR\&.
144141
.TP

support/ab.c

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,6 @@ int bind_count = 0;
435435
const char **bind_hosts;
436436
apr_sockaddr_t **bind_addrs;
437437
apr_port_t connectport;
438-
char *src_address;
439438
const char *gnuplot; /* GNUplot file */
440439
const char *csvperc; /* CSV Percentile file */
441440
const char *fullurl;
@@ -1614,7 +1613,6 @@ static void start_connection(struct connection * c)
16141613
{
16151614
struct worker *worker = c->worker;
16161615
apr_status_t rv;
1617-
apr_sockaddr_t *from;
16181616

16191617
if (!worker_can_connect(worker)) {
16201618
return;
@@ -1680,14 +1678,6 @@ static void start_connection(struct connection * c)
16801678
}
16811679
}
16821680

1683-
if (src_address) {
1684-
if ((rv = apr_sockaddr_info_get(&from, src_address, destsa->family,
1685-
0, 0, c->ctx)) != APR_SUCCESS)
1686-
graceful_strerror("src_address get", rv);
1687-
if ((rv = apr_socket_bind(c->aprsock, from)) != APR_SUCCESS)
1688-
graceful_strerror("src_address bind", rv);
1689-
}
1690-
16911681
c->read = 0;
16921682
c->bread = 0;
16931683
c->length = 0;
@@ -2800,7 +2790,6 @@ static void usage(const char *progname)
28002790
fprintf(stderr, " -P attribute Add Basic Proxy Authentication, the attributes\n");
28012791
fprintf(stderr, " are a colon separated username and password.\n");
28022792
fprintf(stderr, " -X proxy:port Proxyserver and port number to use\n");
2803-
fprintf(stderr, " -o src_address Set the local source address\n");
28042793
fprintf(stderr, " -V Print version number and exit\n");
28052794
fprintf(stderr, " -k Use HTTP KeepAlive feature\n");
28062795
fprintf(stderr, " -d Do not show percentiles served table.\n");
@@ -3041,7 +3030,7 @@ int main(int argc, const char * const argv[])
30413030
#endif
30423031

30433032
apr_getopt_init(&opt, cntxt, argc, argv);
3044-
while ((status = apr_getopt(opt, "n:c:t:s:b:T:p:u:v:lrkVhwiIx:y:z:C:H:P:A:g:X:de:SqQDB:m:R:o:"
3033+
while ((status = apr_getopt(opt, "n:c:t:s:b:T:p:u:v:lrkVhwiIx:y:z:C:H:P:A:g:X:de:SqQDB:m:R:"
30453034
#if APR_HAS_THREADS
30463035
"W:"
30473036
#endif
@@ -3067,9 +3056,6 @@ int main(int argc, const char * const argv[])
30673056
case 'k':
30683057
keepalive = 1;
30693058
break;
3070-
case 'o':
3071-
src_address = strdup(opt_arg);
3072-
break;
30733059
case 'q':
30743060
heartbeatres = 0;
30753061
break;

0 commit comments

Comments
 (0)