Skip to content

Commit 543a0be

Browse files
committed
mod_ssl: Revert r1868929 on trunk (only).
We discussed in 2019 that after 2.4.x's backport r1873907 we should apply normal/usual merging for SSLProtocol in next versions (thus trunk first). See: https://lists.apache.org/thread/76yh7j3fwj2tsmffsqcqpv4mcfph5vqx Make this happen finally. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1921360 13f79535-47bb-0310-9956-ffa450edef68
1 parent 50df6c8 commit 543a0be

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

modules/ssl/ssl_engine_kernel.c

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2612,14 +2612,13 @@ static int ssl_find_vhost(void *servername, conn_rec *c, server_rec *s)
26122612
#if OPENSSL_VERSION_NUMBER >= 0x1010007fL \
26132613
&& (!defined(LIBRESSL_VERSION_NUMBER) \
26142614
|| LIBRESSL_VERSION_NUMBER >= 0x20800000L)
2615-
/*
2616-
* Don't switch the protocol if none is configured for this vhost,
2617-
* the default in this case is still the base server's SSLProtocol.
2618-
*/
2619-
if (myConnCtxConfig(c, sc)->protocol_set) {
2620-
SSL_set_min_proto_version(ssl, SSL_CTX_get_min_proto_version(ctx));
2621-
SSL_set_max_proto_version(ssl, SSL_CTX_get_max_proto_version(ctx));
2622-
}
2615+
/* Switch to the vhost's protocols. Note that 2.4 used to do this
2616+
* only if SSLProtocol was configured/inherited for this vhost, using
2617+
* the base server's SSLProtocol otherwise. From 2.5 usual merging
2618+
* applies.
2619+
*/
2620+
SSL_set_min_proto_version(ssl, SSL_CTX_get_min_proto_version(ctx));
2621+
SSL_set_max_proto_version(ssl, SSL_CTX_get_max_proto_version(ctx));
26232622
#endif
26242623
if ((SSL_get_verify_mode(ssl) == SSL_VERIFY_NONE) ||
26252624
(SSL_num_renegotiations(ssl) == 0)) {

0 commit comments

Comments
 (0)