Skip to content

Commit be19b27

Browse files
committed
Merge r1921311 from trunk: [RTC exception for CI]
CI: Use the image version in the cache keys. This is likely a simpler and more robust fix for the issues with Perl XS builds being cached. Root cause was likely "ubuntu-latest" changing from 22.04 to 24.04. Cache keys will now change when that happens again, preventing reuse of cached builds across OS versions. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1921330 13f79535-47bb-0310-9956-ffa450edef68
1 parent 88ebfaa commit be19b27

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/workflows/linux.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,10 +247,14 @@ jobs:
247247
CONFIG: ${{ matrix.config }}
248248
name: ${{ matrix.name }}
249249
steps:
250+
# JOBID is used in the cache keys, created here as a hash of all
251+
# properties of the environment, including the image OS version,
252+
# compiler flags and any job-specific properties.
250253
- name: Set environment variables
251254
run: |
252255
echo "${{ matrix.env }}" >> $GITHUB_ENV
253-
echo JOBID=`echo "${{ matrix.notest-cflags }} ${{ matrix.env }} ${{ matrix.config }}'"| md5sum - | sed 's/ .*//'` >> $GITHUB_ENV
256+
echo JOBID=`echo "OS=$ImageOS ${{ matrix.notest-cflags }} ${{ matrix.env }} ${{ matrix.config }}" \
257+
| md5sum - | sed 's/ .*//'` >> $GITHUB_ENV
254258
# https://github.com/actions/runner-images/issues/9491#issuecomment-1989718917
255259
- name: Workaround ASAN issue in Ubuntu 22.04
256260
run: sudo sysctl vm.mmap_rnd_bits=28

0 commit comments

Comments
 (0)