Skip to content

Commit d9a2baf

Browse files
committed
*) mod_md: update to version 2.6.7
- Fix a regression in `MDStapleOthers` which broke in v2.6.0 and no longer applied, no matter the configuration. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1930363 13f79535-47bb-0310-9956-ffa450edef68
1 parent c024d5d commit d9a2baf

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

changes-entries/md_v2.6.7.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
*) mod_md: update to version 2.6.7
2+
- Fix a regression in `MDStapleOthers` which broke in v2.6.0 and no longer
3+
applied, no matter the configuration.

modules/md/md_version.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@
2727
* @macro
2828
* Version number of the md module as c string
2929
*/
30-
#define MOD_MD_VERSION "2.6.6"
30+
#define MOD_MD_VERSION "2.6.7-git"
3131

3232
/**
3333
* @macro
3434
* Numerical representation of the version number of the md module
3535
* release. This is a 24 bit number with 8 bits for major number, 8 bits
3636
* for minor and 8 bits for patch. Version 1.2.3 becomes 0x010203.
3737
*/
38-
#define MOD_MD_VERSION_NUM 0x020606
38+
#define MOD_MD_VERSION_NUM 0x020607
3939

4040
#define MD_ACME_DEF_URL "https://acme-v02.api.letsencrypt.org/directory"
4141

modules/md/mod_md_config.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ static void *md_config_merge(apr_pool_t *pool, void *basev, void *addv)
282282
nsc->profile = add->profile? add->profile : base->profile;
283283
nsc->profile_mandatory = (add->profile_mandatory != DEF_VAL)? add->profile_mandatory : base->profile_mandatory;
284284
nsc->stapling = (add->stapling != DEF_VAL)? add->stapling : base->stapling;
285+
nsc->staple_others = (add->staple_others != DEF_VAL)? add->staple_others : base->staple_others;
285286
nsc->ari_renewals = (add->ari_renewals != DEF_VAL)? add->ari_renewals : base->ari_renewals;
286287
nsc->dns01_cmd = (add->dns01_cmd)? add->dns01_cmd : base->dns01_cmd;
287288
nsc->current = NULL;

modules/md/mod_md_ocsp.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,18 @@ int md_ocsp_prime_status(server_rec *s, apr_pool_t *p,
6161
apr_array_header_t *chain;
6262
apr_status_t rv = APR_ENOENT;
6363

64+
ap_log_error(APLOG_MARK, APLOG_TRACE1, 0, s, "ocsp prime status call for: %s",
65+
s->server_hostname);
6466
sc = md_config_get(s);
65-
if (!staple_here(sc)) goto cleanup;
67+
if (!staple_here(sc)) {
68+
ap_log_error(APLOG_MARK, APLOG_TRACE1, 0, s,
69+
"ocsp prime does not apply here: server=%s, sc=%d"
70+
"ocsp=%d, conf-ocsp=%d conf-others=%d",
71+
s->server_hostname, !!sc, sc? !!sc->mc->ocsp : 0,
72+
md_config_geti(sc, MD_CONFIG_STAPLING),
73+
md_config_geti(sc, MD_CONFIG_STAPLE_OTHERS));
74+
goto cleanup;
75+
}
6676

6777
md = ((sc->assigned && sc->assigned->nelts == 1)?
6878
APR_ARRAY_IDX(sc->assigned, 0, const md_t*) : NULL);

0 commit comments

Comments
 (0)