Skip to content

Commit 008684e

Browse files
committed
refactor: separate V1 and V2 ManifestListReader tests
- Rename ManifestListReaderTest to ManifestListReaderV2Test - Rename PrepareTestManifestList to PrepareV2PartitionedTestManifestList - Rename BasicTest to PartitionedTest - Rename V2NonPartitionedTest to NonPartitionedTest - Prepare structure for adding V1 tests
1 parent 99272fc commit 008684e

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

test/manifest_list_reader_test.cc

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,12 @@
2525
#include "iceberg/avro/avro_reader.h"
2626
#include "iceberg/manifest_list.h"
2727
#include "iceberg/manifest_reader.h"
28-
#include "iceberg/schema.h"
29-
#include "matchers.h"
3028
#include "temp_file_test_base.h"
3129
#include "test_common.h"
3230

3331
namespace iceberg {
3432

35-
class ManifestListReaderTest : public TempFileTestBase {
33+
class ManifestListReaderV2Test : public TempFileTestBase {
3634
protected:
3735
static void SetUpTestSuite() { avro::AvroReader::Register(); }
3836

@@ -42,7 +40,7 @@ class ManifestListReaderTest : public TempFileTestBase {
4240
file_io_ = std::make_shared<iceberg::arrow::ArrowFileSystemFileIO>(local_fs_);
4341
}
4442

45-
std::vector<ManifestFile> PrepareTestManifestList() {
43+
std::vector<ManifestFile> PrepareV2PartitionedTestManifestList() {
4644
std::vector<ManifestFile> manifest_files;
4745
std::string test_dir_prefix = "/tmp/db/db/iceberg_test/metadata/";
4846
std::vector<std::string> paths = {"2bccd69e-d642-4816-bba0-261cd9bd0d93-m0.avro",
@@ -121,24 +119,24 @@ class ManifestListReaderTest : public TempFileTestBase {
121119
std::shared_ptr<FileIO> file_io_;
122120
};
123121

124-
TEST_F(ManifestListReaderTest, BasicTest) {
122+
TEST_F(ManifestListReaderV2Test, PartitionedTest) {
125123
std::string path = GetResourcePath(
126124
"snap-7412193043800610213-1-2bccd69e-d642-4816-bba0-261cd9bd0d93.avro");
127125
auto manifest_reader_result = ManifestListReader::MakeReader(path, file_io_);
128126
ASSERT_EQ(manifest_reader_result.has_value(), true);
127+
129128
auto manifest_reader = std::move(manifest_reader_result.value());
130129
auto read_result = manifest_reader->Files();
131130
ASSERT_EQ(read_result.has_value(), true);
132131
ASSERT_EQ(read_result.value().size(), 4);
133132

134-
auto expected_manifest_list = PrepareTestManifestList();
133+
auto expected_manifest_list = PrepareV2PartitionedTestManifestList();
135134
ASSERT_EQ(read_result.value(), expected_manifest_list);
136135
}
137136

138-
TEST_F(ManifestListReaderTest, V2NonPartitionedTest) {
137+
TEST_F(ManifestListReaderV2Test, NonPartitionedTest) {
139138
std::string path = GetResourcePath(
140139
"snap-251167482216575399-1-ccb6dbcb-0611-48da-be68-bd506ea63188.avro");
141-
142140
auto manifest_reader_result = ManifestListReader::MakeReader(path, file_io_);
143141
ASSERT_EQ(manifest_reader_result.has_value(), true);
144142

0 commit comments

Comments
 (0)