Skip to content

Commit 012966f

Browse files
committed
some NotImplement -> NotSupported
1 parent d125408 commit 012966f

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/iceberg/literal.cc

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ Result<PrimitiveLiteral> PrimitiveLiteral::CastFromInt(TypeId target_type_id) co
130130
return PrimitiveLiteral::Float(static_cast<float>(int_val));
131131
case TypeId::kDouble:
132132
return PrimitiveLiteral::Double(static_cast<double>(int_val));
133-
// TODO(mwish): Supports casts to date and literal
134133
default:
135134
return NotSupported("Cast from Int to {} is not implemented",
136135
static_cast<int>(target_type_id));
@@ -156,8 +155,8 @@ Result<PrimitiveLiteral> PrimitiveLiteral::CastFromLong(TypeId target_type_id) c
156155
case TypeId::kDouble:
157156
return PrimitiveLiteral::Double(static_cast<double>(long_val));
158157
default:
159-
return NotImplemented("Cast from Long to {} is not implemented",
160-
static_cast<int>(target_type_id));
158+
return NotSupported("Cast from Long to {} is not supported",
159+
static_cast<int>(target_type_id));
161160
}
162161
}
163162

@@ -168,8 +167,8 @@ Result<PrimitiveLiteral> PrimitiveLiteral::CastFromFloat(TypeId target_type_id)
168167
case TypeId::kDouble:
169168
return PrimitiveLiteral::Double(static_cast<double>(float_val));
170169
default:
171-
return NotImplemented("Cast from Float to {} is not implemented",
172-
static_cast<int>(target_type_id));
170+
return NotSupported("Cast from Float to {} is not supported",
171+
static_cast<int>(target_type_id));
173172
}
174173
}
175174

0 commit comments

Comments
 (0)