1

Author: HeartLinked

src/iceberg/catalog/rest/validator.cc

@@ -22,6 +22,7 @@
 #include <format>
 #include <ranges>
 #include <unordered_set>
+#include <utility>
 
 #include "iceberg/catalog/rest/types.h"
 #include "iceberg/result.h"
@@ -69,20 +70,23 @@ Status Validator::Validate(const UpdateNamespacePropertiesRequest& request) {
     return {};
   }
 
-  std::unordered_set<std::string> remove_set(std::from_range, request.removals);
+  std::unordered_set<std::string> remove_set(request.removals.begin(),
+                                             request.removals.end());
+  std::vector<std::string> common;
 
-  auto common =
-      request.updates | std::views::keys |
-      std::views::filter([&](const std::string& k) { return remove_set.contains(k); }) |
-      std::ranges::to<std::vector<std::string>>();
+  for (const std::string& k : request.updates | std::views::keys) {
+    if (remove_set.contains(k)) {
+      common.push_back(k);
+    }
+  }
 
   if (!common.empty()) {
     std::string keys;
     bool first = true;
-    std::ranges::for_each(common, [&](const std::string& s) {
+    for (const std::string& s : common) {
       if (!std::exchange(first, false)) keys += ", ";
       keys += s;
-    });
+    }
 
     return Invalid(
         "Invalid namespace properties update: cannot simultaneously set and remove keys: "