chore: Add release automation infrastructure

HeartLinked · HeartLinked · commit 07510c5a378b · 2025-08-27T18:30:50.000+08:00
diff --git a/.github/workflows/rc.yml b/.github/workflows/rc.yml
@@ -15,81 +15,130 @@
 # specific language governing permissions and limitations
 # under the License.
 
-name: Release Candidate
-
+name: RC
 on:
   push:
     tags:
-      - 'v*-rc*'
+      - '*-rc*'
+
+concurrency:
+  group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+  cancel-in-progress: true
+permissions:
+  contents: read
 
 jobs:
-  build-source-tarball:
+  archive:
+    name: Archive
     runs-on: ubuntu-latest
-
+    timeout-minutes: 5
     steps:
-      - name: Checkout repository
+      - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Extract version from tag
-        id: extract_version
+      - name: Prepare for tag
+        if: github.ref_type == 'tag'
         run: |
-          TAG_NAME=${GITHUB_REF#refs/tags/}
-          echo "tag_name=${TAG_NAME}" >> $GITHUB_OUTPUT
-          VERSION=$(echo ${TAG_NAME} | sed 's/^v//' | sed 's/-rc.*$//')
-          RC=$(echo ${TAG_NAME} | sed 's/.*-rc//')
-          echo "version=${VERSION}" >> $GITHUB_OUTPUT
-          echo "rc=${RC}" >> $GITHUB_OUTPUT
-          echo "release_id=apache-iceberg-cpp-${VERSION}-rc${RC}" >> $GITHUB_OUTPUT
+          version=${GITHUB_REF_NAME#v}
+          version=${version%-rc*}
+          rc=${GITHUB_REF_NAME##*-rc}
+          echo "VERSION=${version}" >> ${GITHUB_ENV}
+          echo "RC=${rc}" >> ${GITHUB_ENV}
+          echo "VERSION=${version}"
+          echo "RC=${rc}"
 
-      - name: Install dependencies
+      - name: Archive
         run: |
-          sudo apt-get update
-          sudo apt-get install -y cmake build-essential
+          id="apache-iceberg-cpp-${VERSION}-rc${RC}"
+          tar_gz="${id}.tar.gz"
+          echo "TAR_GZ=${tar_gz}" >> ${GITHUB_ENV}
+          git archive HEAD --prefix "${id}/" --output "${tar_gz}"
+          sha512sum "${tar_gz}" > "${tar_gz}.sha512"
 
-      - name: Create source tarball
+      - name: Audit
         run: |
-          # Create archive with git
-          git archive --format=tar.gz --output="${{ steps.extract_version.outputs.release_id }}.tar.gz" --prefix="${{ steps.extract_version.outputs.release_id }}/" HEAD
-
-          # Generate SHA512 checksum
-          sha512sum "${{ steps.extract_version.outputs.release_id }}.tar.gz" > "${{ steps.extract_version.outputs.release_id }}.tar.gz.sha512"
+          dev/release/run_rat.sh "${TAR_GZ}"
 
-          # Verify the tarball can be extracted and built
-          tar -xzf "${{ steps.extract_version.outputs.release_id }}.tar.gz"
-          cd "${{ steps.extract_version.outputs.release_id }}"
+      - uses: actions/upload-artifact@v4
+        with:
+          name: archive
+          path: |
+            apache-iceberg-cpp-*
 
-          # Basic build test
-          cmake -S . -B build -DCMAKE_BUILD_TYPE=Release
-          cmake --build build --parallel $(nproc)
+  verify:
+    name: Verify
+    needs:
+      - archive
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - macos-latest
+          - ubuntu-latest
+          # - windows-latest
+    steps:
+      - name: Install C++ Build Tools (Ubuntu)
+        if: runner.os == 'Linux'
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y build-essential cmake ninja-build libssl-dev
 
-      - name: Run license check
+      - name: Install C++ Build Tools (macOS)
+        if: runner.os == 'macOS'
         run: |
-          # Extract the tarball if not already extracted
-          if [ ! -d "${{ steps.extract_version.outputs.release_id }}" ]; then
-            tar -xzf "${{ steps.extract_version.outputs.release_id }}.tar.gz"
-          fi
+          brew install cmake ninja openssl
 
-          cd "${{ steps.extract_version.outputs.release_id }}"
-          dev/release/run_rat.sh .
+      - name: Checkout
+        uses: actions/checkout@v4
 
-      - name: Create GitHub Release
-        uses: softprops/action-gh-release@v1
+      - uses: actions/download-artifact@v4
         with:
-          tag_name: ${{ steps.extract_version.outputs.tag_name }}
-          name: Apache Iceberg C++ ${{ steps.extract_version.outputs.version }} RC${{ steps.extract_version.outputs.rc }}
-          prerelease: true
-          draft: false
-          files: |
-            ${{ steps.extract_version.outputs.release_id }}.tar.gz
-            ${{ steps.extract_version.outputs.release_id }}.tar.gz.sha512
+          name: archive
+
+      - name: Verify
+        run: |
+          tar_gz=$(echo apache-iceberg-cpp-*.tar.gz)
+          version=${tar_gz#apache-iceberg-cpp-}
+          version=${version%.tar.gz}
+          version=${version%%-rc*}
+          if [ "${GITHUB_REF_TYPE}" = "tag" ]; then
+            rc=${GITHUB_REF_NAME##*-rc}
+          else
+            rc=100
+          fi
+          echo "VERSION=${version}"
+          echo "RC=${rc}"
+          # The verify_rc.sh script will untar and
+          # run cmake, build, tests (ctest) and install
+          VERIFY_SIGN=0 VERIFY_DOWNLOAD=0 dev/release/verify_rc.sh "${version}" "${rc}"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Upload artifacts
-        uses: actions/upload-artifact@v4
+  upload:
+    name: Upload
+    if: github.ref_type == 'tag'
+    needs:
+      - verify
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    steps:
+      - name: Checkout
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+
+      - uses: actions/download-artifact@v4
         with:
-          name: release-candidate-${{ steps.extract_version.outputs.version }}-rc${{ steps.extract_version.outputs.rc }}
-          path: |
-            ${{ steps.extract_version.outputs.release_id }}.tar.gz
-            ${{ steps.extract_version.outputs.release_id }}.tar.gz.sha512
-          retention-days: 30
+          name: archive
+
+      - name: Upload
+        run: |
+          gh release create ${GITHUB_REF_NAME} \
+            --prerelease \
+            --title "Apache Iceberg C++ ${GITHUB_REF_NAME}" \
+            --generate-notes \
+            --verify-tag \
+            apache-iceberg-cpp-*.tar.gz \
+            apache-iceberg-cpp-*.tar.gz.sha*
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/dev/release/README.md b/dev/release/README.md
@@ -1,18 +1,20 @@
-<!---
-  Licensed to the Apache Software Foundation (ASF) under one
-  or more contributor license agreements.  See the NOTICE file
-  distributed with this work for additional information
-  regarding copyright ownership.  The ASF licenses this file
-  to you under the Apache License, Version 2.0 (the
-  "License"); you may not use this file except in compliance
-  with the License.  You may obtain a copy of the License at
-    http://www.apache.org/licenses/LICENSE-2.0
-  Unless required by applicable law or agreed to in writing,
-  software distributed under the License is distributed on an
-  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-  KIND, either express or implied.  See the License for the
-  specific language governing permissions and limitations
-  under the License.
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~   http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing,
+  ~ software distributed under the License is distributed on an
+  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  ~ KIND, either express or implied.  See the License for the
+  ~ specific language governing permissions and limitations
+  ~ under the License.
 -->
 
 # Release
@@ -35,13 +37,13 @@ $ dev/release/release_rc.sh ${VERSION} ${RC}
  You can use a draft shown by release_rc.sh for the email.)
 ```
 
-Here is an example to release RC1:
+Here is an example to release RC0 of version 0.1.0:
 
 ```console
-$ GH_TOKEN=${YOUR_GITHUB_TOKEN} dev/release/release_rc.sh 0.1.0 1
+$ GH_TOKEN=${YOUR_GITHUB_TOKEN} dev/release/release_rc.sh 0.1.0 0
 ```
 
-The arguments of `release_rc.sh` are the version and the RC number. If RC1 has a problem, we'll increment the RC number such as RC2, RC3 and so on.
+The arguments of `release_rc.sh` are the version and the RC number. If RC0 has a problem, we'll increment the RC number such as RC1, RC2 and so on.
 
 Requirements to run `release_rc.sh`:
 
@@ -69,9 +71,7 @@ $ svn ci KEYS
 
 ### Publish
 
-We need to do the following to publish a new release:
-
-    * Publish to apache.org
+We need to publish to apache.org to publish a new release.
 
 Run `dev/release/release.sh` to publish to apache.org:
 
diff --git a/dev/release/check_rat_report.py b/dev/release/check_rat_report.py
@@ -30,7 +30,13 @@
 exclude_globs_filename = sys.argv[1]
 xml_filename = sys.argv[2]
 
-globs = [line.strip() for line in open(exclude_globs_filename, "r")]
+globs = []
+with open(exclude_globs_filename, "r") as f:
+    for line in f:
+        stripped_line = line.strip()
+        if not stripped_line or stripped_line.startswith('#'):
+            continue
+        globs.append(stripped_line)
 
 tree = ET.parse(xml_filename)
 root = tree.getroot()
diff --git a/dev/release/rat_exclude_files.txt b/dev/release/rat_exclude_files.txt
@@ -18,22 +18,11 @@
 .gitignore
 LICENSE
 NOTICE
-CLAUDE.md
-README.md
-CONTRIBUTING.md
-CHANGELOG.md
-build/
-dist/
-.github/
-.git/
-cmake_modules/
-.cmake/
-.clang-format
-.clang-tidy
-.pre-commit-config.yaml
-CMakeUserPresets.json
-test/resources/
-cmake-format.py
+build/**
+dist/**
+.git/**
+test/resources/**
 *.avro
 *.json
 *.parquet
+src/iceberg/util/murmurhash3_internal.*
diff --git a/dev/release/release_rc.sh b/dev/release/release_rc.sh
@@ -49,10 +49,8 @@ cd "${SOURCE_TOP_DIR}"
 
 if [ "${RELEASE_PULL}" -gt 0 ] || [ "${RELEASE_PUSH_TAG}" -gt 0 ]; then
   git_origin_url="$(git remote get-url origin)"
-  if [ "${git_origin_url}" != "git@github.com:HeartLinked/iceberg-cpp.git" ]; then
-    echo "This script must be ran with working copy of HeartLinked/iceberg-cpp."
-  # if [ "${git_origin_url}" != "git@github.com:apache/iceberg-cpp.git" ]; then
-    # echo "This script must be ran with working copy of apache/iceberg-cpp."
+  if [ "${git_origin_url}" != "git@github.com:apache/iceberg-cpp.git" ]; then
+    echo "This script must be ran with working copy of apache/iceberg-cpp."
     echo "The origin's URL: ${git_origin_url}"
     exit 1
   fi
@@ -96,7 +94,6 @@ if [ "${RELEASE_SIGN}" -gt 0 ]; then
   echo "Found GitHub Actions workflow with ID: ${run_id}"
   gh run watch --repo "${repository}" --exit-status "${run_id}"
 
-  # Create release candidate directory structure
   mkdir -p "${id}"
 
   echo "Downloading .tar.gz from GitHub Releases"
diff --git a/dev/release/verify_rc.sh b/dev/release/verify_rc.sh
@@ -113,49 +113,6 @@ ensure_source_directory() {
   tar xf "${ARCHIVE_BASE_NAME}".tar.gz
 }
 
-check_compiler() {
-  echo "--- Verifying Build Environment ---"
-
-  # Check for minimum CMake version (e.g., 3.25)
-  MIN_CMAKE_VERSION="3.25"
-  CMAKE_VERSION=$(cmake --version | head -n1 | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')
-  echo "Found CMake version: $CMAKE_VERSION"
-  if [ "$(printf '%s\n' "${MIN_CMAKE_VERSION}" "${CMAKE_VERSION}" | sort -V | head -n1)" != "${MIN_CMAKE_VERSION}" ]; then
-    echo "ERROR: CMake ${MIN_CMAKE_VERSION} or higher is required, but found ${CMAKE_VERSION}."
-    exit 1
-  fi
-
-  # Check for C++23 compliant compiler
-  local compiler_ok=0
-  if command -v g++ >/dev/null 2>&1; then
-    # Get major version: g++ (Debian 13.2.0-4) 13.2.0 -> 13
-    GCC_MAJOR_VERSION=$(g++ -dumpversion | cut -d. -f1)
-    echo "Found GCC version: $(g++ --version | head -n1)"
-    # GCC 13 is the first version with full C++23 support
-    if [ "${GCC_MAJOR_VERSION}" -ge 13 ]; then
-      echo "GCC version is sufficient for C++23."
-      compiler_ok=1
-    fi
-  fi
-
-  if [ "${compiler_ok}" -eq 0 ] && command -v clang++ >/dev/null 2>&1; then
-    CLANG_MAJOR_VERSION=$(clang++ --version | head -n1 | grep -oE '[0-9]+' | head -n1)
-    echo "Found Clang version: $(clang++ --version | head -n1)"
-    # Clang 16 is the first version with full C++23 support
-    if [ "${CLANG_MAJOR_VERSION}" -ge 16 ]; then
-      echo "Clang version is sufficient for C++23."
-      compiler_ok=1
-    fi
-  fi
-
-  if [ "${compiler_ok}" -eq 0 ]; then
-    echo "ERROR: No C++23 compliant compiler found (GCC 13+ or Clang 16+ required)."
-    exit 1
-  fi
-
-  echo "--- Environment check passed ---"
-}
-
 test_source_distribution() {
   echo "Building and testing Apache Iceberg C++..."
 
@@ -171,7 +128,11 @@ test_source_distribution() {
   # Run tests
   ctest --test-dir build --output-on-failure --parallel $(nproc || sysctl -n hw.ncpu || echo 4)
 
-  echo "Build and test completed successfully!"
+  # Install
+  mkdir -p ./install_test
+  cmake --install build --prefix ./install_test
+
+  echo "Build, test and install completed successfully!"
 }
 
 setup_tmpdir "iceberg-cpp-${VERSION}-${RC}"
@@ -181,7 +142,6 @@ cd "${VERIFY_TMPDIR}"
 import_gpg_keys
 fetch_archive
 ensure_source_directory
-check_compiler
 pushd "${ARCHIVE_BASE_NAME}"
 test_source_distribution
 popd
diff --git a/website/src/release.md b/website/src/release.md
