Skip to content

Commit 0fc573a

Browse files
authored
feat: add decimal value representation (#182)
1 parent 9b69e45 commit 0fc573a

File tree

10 files changed

+1530
-1
lines changed

10 files changed

+1530
-1
lines changed

LICENSE

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,14 @@ The file src/iceberg/util/visit_type.h contains code adapted from
250250

251251
https://github.com/apache/arrow/blob/main/cpp/src/arrow/visit_type_inline.h
252252

253+
The file src/iceberg/util/decimal.h contains code adapted from
254+
255+
https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.h
256+
257+
The file src/iceberg/util/decimal.cc contains code adapted from
258+
259+
https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.cc
260+
253261
Copyright: 2016-2025 The Apache Software Foundation.
254262
Home page: https://arrow.apache.org/
255263
License: https://www.apache.org/licenses/LICENSE-2.0

src/iceberg/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ set(ICEBERG_SOURCES
4949
manifest_reader_internal.cc
5050
manifest_writer.cc
5151
arrow_c_data_guard_internal.cc
52+
util/decimal.cc
5253
util/murmurhash3_internal.cc
5354
util/timepoint.cc
5455
util/gzip_internal.cc)

src/iceberg/inheritable_metadata.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
#include "iceberg/inheritable_metadata.h"
2121

22-
#include <cassert>
2322
#include <utility>
2423

2524
#include <iceberg/result.h>

src/iceberg/result.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ enum class ErrorKind {
3232
kAlreadyExists,
3333
kCommitStateUnknown,
3434
kDecompressError,
35+
kInvalid, // For general invalid errors
3536
kInvalidArgument,
3637
kInvalidArrowData,
3738
kInvalidExpression,
@@ -79,6 +80,7 @@ using Status = Result<void>;
7980
DEFINE_ERROR_FUNCTION(AlreadyExists)
8081
DEFINE_ERROR_FUNCTION(CommitStateUnknown)
8182
DEFINE_ERROR_FUNCTION(DecompressError)
83+
DEFINE_ERROR_FUNCTION(Invalid)
8284
DEFINE_ERROR_FUNCTION(InvalidArgument)
8385
DEFINE_ERROR_FUNCTION(InvalidArrowData)
8486
DEFINE_ERROR_FUNCTION(InvalidExpression)

0 commit comments

Comments
 (0)