fix review

HuaHuaY · HuaHuaY · commit 117b480764b7 · 2025-09-02T11:21:34.000+08:00
diff --git a/src/iceberg/arrow/arrow_error_transform_internal.h b/src/iceberg/arrow/arrow_error_transform_internal.h
@@ -30,6 +30,8 @@ inline ErrorKind ToErrorKind(const ::arrow::Status& status) {
   switch (status.code()) {
     case ::arrow::StatusCode::IOError:
       return ErrorKind::kIOError;
+    case ::arrow::StatusCode::NotImplemented:
+      return ErrorKind::kNotImplemented;
     default:
       return ErrorKind::kUnknownError;
   }
diff --git a/test/parquet_test.cc b/test/parquet_test.cc
@@ -310,7 +310,7 @@ TEST_F(ParquetReadWrite, EmptyStruct) {
   const std::string basePath = "base.parquet";
 
   ASSERT_THAT(WriteTable(array, {.path = basePath, .schema = schema, .io = file_io}),
-              IsError(ErrorKind::kUnknownError));
+              IsError(ErrorKind::kNotImplemented));
 }
 
 TEST_F(ParquetReadWrite, SimpleStructRoundTrip) {

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,8 @@ inline ErrorKind ToErrorKind(const ::arrow::Status& status) {`
`30`	`30`	`switch (status.code()) {`
`31`	`31`	`case ::arrow::StatusCode::IOError:`
`32`	`32`	`return ErrorKind::kIOError;`
	`33`	`+ case ::arrow::StatusCode::NotImplemented:`
	`34`	`+ return ErrorKind::kNotImplemented;`
`33`	`35`	`default:`
`34`	`36`	`return ErrorKind::kUnknownError;`
`35`	`37`	`}`
Original file line number	Diff line number	Diff line change
`@@ -310,7 +310,7 @@ TEST_F(ParquetReadWrite, EmptyStruct) {`
`310`	`310`	`const std::string basePath = "base.parquet";`
`311`	`311`
`312`	`312`	`ASSERT_THAT(WriteTable(array, {.path = basePath, .schema = schema, .io = file_io}),`
`313`		`- IsError(ErrorKind::kUnknownError));`
	`313`	`+ IsError(ErrorKind::kNotImplemented));`
`314`	`314`	`}`
`315`	`315`
`316`	`316`	`TEST_F(ParquetReadWrite, SimpleStructRoundTrip) {`