Skip to content

Commit 121f8a7

Browse files
committed
Try fixing Cmake Win visibility regression
1 parent 9f4e8cc commit 121f8a7

File tree

1 file changed

+22
-2
lines changed

1 file changed

+22
-2
lines changed

src/iceberg/CMakeLists.txt

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,17 @@ add_iceberg_lib(iceberg
9494
STATIC_INSTALL_INTERFACE_LIBS
9595
${ICEBERG_STATIC_INSTALL_INTERFACE_LIBS}
9696
SHARED_INSTALL_INTERFACE_LIBS
97-
${ICEBERG_SHARED_INSTALL_INTERFACE_LIBS})
97+
${ICEBERG_SHARED_INSTALL_INTERFACE_LIBS}
98+
OUTPUTS
99+
ICEBERG_LIBRARIES)
100+
101+
foreach(LIB_TARGET ${ICEBERG_LIBRARIES})
102+
target_compile_definitions(${LIB_TARGET} PRIVATE ICEBERG_EXPORTING)
103+
endforeach()
104+
105+
if(ICEBERG_BUILD_STATIC)
106+
target_compile_definitions(iceberg_static PUBLIC ICEBERG_STATIC)
107+
endif()
98108

99109
iceberg_install_all_headers(iceberg)
100110

@@ -163,7 +173,17 @@ if(ICEBERG_BUILD_BUNDLE)
163173
STATIC_INSTALL_INTERFACE_LIBS
164174
${ICEBERG_BUNDLE_STATIC_INSTALL_INTERFACE_LIBS}
165175
SHARED_INSTALL_INTERFACE_LIBS
166-
${ICEBERG_BUNDLE_SHARED_INSTALL_INTERFACE_LIBS})
176+
${ICEBERG_BUNDLE_SHARED_INSTALL_INTERFACE_LIBS}
177+
OUTPUT
178+
ICEBERG_BUNDLE_LIBRARIES)
179+
180+
foreach(LIB_TARGET ${ICEBERG_BUNDLE_LIBRARIES})
181+
target_compile_definitions(${LIB_TARGET} PRIVATE ICEBERG_BUNDLE_EXPORTING)
182+
endforeach()
183+
184+
if(ICEBERG_BUILD_STATIC)
185+
target_compile_definitions(iceberg_bundle_static PUBLIC ICEBERG_BUNDLE_STATIC)
186+
endif()
167187

168188
add_subdirectory(arrow)
169189
add_subdirectory(avro)

0 commit comments

Comments
 (0)