Skip to content

Commit 1775519

Browse files
committed
feat: add residual evaluator
1 parent 316b325 commit 1775519

File tree

9 files changed

+1271
-3
lines changed

9 files changed

+1271
-3
lines changed

src/iceberg/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ set(ICEBERG_SOURCES
2828
expression/inclusive_metrics_evaluator.cc
2929
expression/literal.cc
3030
expression/predicate.cc
31+
expression/residual_evaluator.cc
3132
expression/rewrite_not.cc
3233
expression/strict_metrics_evaluator.cc
3334
expression/term.cc

src/iceberg/expression/expression_visitor.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,10 +260,8 @@ class ICEBERG_EXPORT BoundVisitor : public ExpressionVisitor<R> {
260260

261261
/// \brief Visit an unbound predicate.
262262
///
263-
/// Bound visitors do not support unbound predicates.
264-
///
265263
/// \param pred The unbound predicate
266-
Result<R> Predicate(const std::shared_ptr<UnboundPredicate>& pred) final {
264+
Result<R> Predicate(const std::shared_ptr<UnboundPredicate>& pred) override {
267265
ICEBERG_DCHECK(pred != nullptr, "UnboundPredicate cannot be null");
268266
return NotSupported("Not a bound predicate: {}", pred->ToString());
269267
}

src/iceberg/expression/meson.build

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ install_headers(
2626
'inclusive_metrics_evaluator.h',
2727
'literal.h',
2828
'predicate.h',
29+
'residual_evaluator.h',
2930
'rewrite_not.h',
3031
'strict_metrics_evaluator.h',
3132
'term.h',

0 commit comments

Comments
 (0)