chore: export the headers

Signed-off-by: Junwang Zhao <[email protected]>

Author: zhjwpku

src/iceberg/CMakeLists.txt

@@ -39,7 +39,7 @@ set(ICEBERG_SOURCES
     type.cc
     util/murmurhash3_internal.cc
     util/timepoint.cc
-    util/unreachable_internal.cc)
+    util/unreachable.cc)
 
 set(ICEBERG_STATIC_BUILD_INTERFACE_LIBS)
 set(ICEBERG_SHARED_BUILD_INTERFACE_LIBS)

src/iceberg/util/checked_cast_internal.h renamed to src/iceberg/util/checked_cast.h

@@ -17,13 +17,15 @@
  * under the License.
  */
 
-#include "iceberg/util/unreachable_internal.h"
+#include "iceberg/util/unreachable.h"
 
-namespace iceberg {
+#include <cstdlib>
+
+namespace iceberg::internal {
 
 // TODO(anyone): log the message before aborting
 [[noreturn]] void Unreachable([[maybe_unused]] const char* message) { std::abort(); }
 
 [[noreturn]] void Unreachable([[maybe_unused]] std::string_view message) { std::abort(); }
 
-}  // namespace iceberg
+}  // namespace iceberg::internal

src/iceberg/util/unreachable_internal.cc renamed to src/iceberg/util/unreachable.cc

@@ -23,11 +23,11 @@
 
 #include "iceberg/iceberg_export.h"
 
-namespace iceberg {
+namespace iceberg::internal {
 
 [[noreturn]] ICEBERG_EXPORT void Unreachable(
     [[maybe_unused]] const char* message = "Unreachable");
 
 [[noreturn]] ICEBERG_EXPORT void Unreachable([[maybe_unused]] std::string_view message);
 
-}  // namespace iceberg
+}  // namespace iceberg::internal

src/iceberg/util/unreachable_internal.h renamed to src/iceberg/util/unreachable.h

@@ -21,9 +21,9 @@
 
 #include "iceberg/result.h"
 #include "iceberg/type.h"
-#include "iceberg/util/checked_cast_internal.h"
-#include "iceberg/util/unreachable_internal.h"
-#include "iceberg/util/visitor_generate_internal.h"
+#include "iceberg/util/checked_cast.h"
+#include "iceberg/util/unreachable.h"
+#include "iceberg/util/visitor_generate.h"
 
 namespace iceberg {
 
@@ -88,7 +88,7 @@ inline auto VisitType(const Type& type, VISITOR&& visitor, ARGS&&... args)
   switch (type.type_id()) {
     ICEBERG_GENERATE_FOR_ALL_TYPES(TYPE_VISIT_INLINE);
     default:
-      Unreachable("Type not implemented");
+      internal::Unreachable("Type not implemented");
   }
 }
 

src/iceberg/util/visit_type_internal.h renamed to src/iceberg/util/visit_type.h

@@ -58,8 +58,7 @@ target_link_libraries(json_serde_test PRIVATE iceberg_static GTest::gtest_main
 add_test(NAME json_serde_test COMMAND json_serde_test)
 
 add_executable(util_test)
-target_sources(util_test PRIVATE expected_test.cc formatter_test.cc config_test.cc
-                                 visit_type_internal_test.cc)
+target_sources(util_test PRIVATE expected_test.cc formatter_test.cc config_test.cc visit_type_test.cc)
 target_link_libraries(util_test PRIVATE iceberg_static GTest::gtest_main GTest::gmock)
 add_test(NAME util_test COMMAND util_test)
 

src/iceberg/util/visitor_generate_internal.h renamed to src/iceberg/util/visitor_generate.h

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-#include "iceberg/util/visit_type_internal.h"
+#include "iceberg/util/visit_type.h"
 
 #include <sstream>