refactor: remove -isystem on local include header files

Author: HuaHuaY

cmake_modules/IcebergBuildUtils.cmake

@@ -131,7 +131,7 @@ function(add_iceberg_lib LIB_NAME)
     endif()
 
     if(LIB_INCLUDES)
-      target_include_directories(${LIB_NAME}_shared SYSTEM PUBLIC ${ARG_EXTRA_INCLUDES})
+      target_include_directories(${LIB_NAME}_shared PUBLIC ${ARG_EXTRA_INCLUDES})
     endif()
 
     if(ARG_PRIVATE_INCLUDES)
@@ -179,7 +179,7 @@ function(add_iceberg_lib LIB_NAME)
     endif()
 
     if(LIB_INCLUDES)
-      target_include_directories(${LIB_NAME}_static SYSTEM PUBLIC ${ARG_EXTRA_INCLUDES})
+      target_include_directories(${LIB_NAME}_static PUBLIC ${ARG_EXTRA_INCLUDES})
     endif()
 
     if(ARG_PRIVATE_INCLUDES)

src/iceberg/transform.cc

@@ -27,41 +27,6 @@
 #include "iceberg/type.h"
 
 namespace iceberg {
-namespace {
-constexpr std::string_view kUnknownName = "unknown";
-constexpr std::string_view kIdentityName = "identity";
-constexpr std::string_view kBucketName = "bucket";
-constexpr std::string_view kTruncateName = "truncate";
-constexpr std::string_view kYearName = "year";
-constexpr std::string_view kMonthName = "month";
-constexpr std::string_view kDayName = "day";
-constexpr std::string_view kHourName = "hour";
-constexpr std::string_view kVoidName = "void";
-}  // namespace
-
-constexpr std::string_view TransformTypeToString(TransformType type) {
-  switch (type) {
-    case TransformType::kUnknown:
-      return kUnknownName;
-    case TransformType::kIdentity:
-      return kIdentityName;
-    case TransformType::kBucket:
-      return kBucketName;
-    case TransformType::kTruncate:
-      return kTruncateName;
-    case TransformType::kYear:
-      return kYearName;
-    case TransformType::kMonth:
-      return kMonthName;
-    case TransformType::kDay:
-      return kDayName;
-    case TransformType::kHour:
-      return kHourName;
-    case TransformType::kVoid:
-      return kVoidName;
-  }
-  std::unreachable();
-}
 
 std::shared_ptr<Transform> Transform::Identity() {
   static auto instance =

src/iceberg/transform.h

@@ -56,8 +56,40 @@ enum class TransformType {
   kVoid,
 };
 
+constexpr std::string_view kUnknownName = "unknown";
+constexpr std::string_view kIdentityName = "identity";
+constexpr std::string_view kBucketName = "bucket";
+constexpr std::string_view kTruncateName = "truncate";
+constexpr std::string_view kYearName = "year";
+constexpr std::string_view kMonthName = "month";
+constexpr std::string_view kDayName = "day";
+constexpr std::string_view kHourName = "hour";
+constexpr std::string_view kVoidName = "void";
+
 /// \brief Get the relative transform name
-ICEBERG_EXPORT constexpr std::string_view TransformTypeToString(TransformType type);
+ICEBERG_EXPORT constexpr std::string_view TransformTypeToString(TransformType type) {
+  switch (type) {
+    case TransformType::kUnknown:
+      return kUnknownName;
+    case TransformType::kIdentity:
+      return kIdentityName;
+    case TransformType::kBucket:
+      return kBucketName;
+    case TransformType::kTruncate:
+      return kTruncateName;
+    case TransformType::kYear:
+      return kYearName;
+    case TransformType::kMonth:
+      return kMonthName;
+    case TransformType::kDay:
+      return kDayName;
+    case TransformType::kHour:
+      return kHourName;
+    case TransformType::kVoid:
+      return kVoidName;
+  }
+  std::unreachable();
+}
 
 /// \brief Represents a transform used in partitioning or sorting in Iceberg.
 ///