fix: add explicit keyword and update method calls

- Add explicit keyword to ManifestReaderImpl and ManifestListReaderImpl
  constructors to prevent unintended implicit conversions
- Update table_scan.cc to use the new Make method names instead of
  deprecated MakeReader methods

Author: HeartLinked

src/iceberg/manifest_reader_internal.h

@@ -31,8 +31,9 @@ namespace iceberg {
 /// \brief Read manifest entries from a manifest file.
 class ManifestReaderImpl : public ManifestReader {
  public:
-  ManifestReaderImpl(std::unique_ptr<Reader> reader, std::shared_ptr<Schema> schema,
-                     std::unique_ptr<InheritableMetadata> inheritable_metadata)
+  explicit ManifestReaderImpl(std::unique_ptr<Reader> reader,
+                              std::shared_ptr<Schema> schema,
+                              std::unique_ptr<InheritableMetadata> inheritable_metadata)
       : schema_(std::move(schema)),
         reader_(std::move(reader)),
         inheritable_metadata_(std::move(inheritable_metadata)) {}
@@ -50,7 +51,8 @@ class ManifestReaderImpl : public ManifestReader {
 /// \brief Read manifest files from a manifest list file.
 class ManifestListReaderImpl : public ManifestListReader {
  public:
-  ManifestListReaderImpl(std::unique_ptr<Reader> reader, std::shared_ptr<Schema> schema)
+  explicit ManifestListReaderImpl(std::unique_ptr<Reader> reader,
+                                  std::shared_ptr<Schema> schema)
       : schema_(std::move(schema)), reader_(std::move(reader)) {}
   ManifestListReaderImpl() = default;
 

src/iceberg/table_scan.cc

@@ -147,17 +147,17 @@ DataTableScan::DataTableScan(TableScanContext context, std::shared_ptr<FileIO> f
 Result<std::vector<std::shared_ptr<FileScanTask>>> DataTableScan::PlanFiles() const {
   ICEBERG_ASSIGN_OR_RAISE(
       auto manifest_list_reader,
-      ManifestListReader::MakeReader(context_.snapshot->manifest_list, file_io_));
+      ManifestListReader::Make(context_.snapshot->manifest_list, file_io_));
   ICEBERG_ASSIGN_OR_RAISE(auto manifest_files, manifest_list_reader->Files());
 
   std::vector<std::shared_ptr<FileScanTask>> tasks;
   ICEBERG_ASSIGN_OR_RAISE(auto partition_spec, context_.table_metadata->PartitionSpec());
   auto partition_schema = partition_spec->schema();
 
   for (const auto& manifest_file : manifest_files) {
-    ICEBERG_ASSIGN_OR_RAISE(auto manifest_reader,
-                            ManifestReader::MakeReader(manifest_file.manifest_path,
-                                                       file_io_, partition_schema));
+    ICEBERG_ASSIGN_OR_RAISE(
+        auto manifest_reader,
+        ManifestReader::Make(manifest_file, file_io_, partition_schema));
     ICEBERG_ASSIGN_OR_RAISE(auto manifests, manifest_reader->Entries());
 
     // TODO(gty404): filter manifests using partition spec and filter expression