add operator== to literal

Author: xiao.dong

src/iceberg/expression/literal.cc

@@ -179,6 +179,10 @@ std::strong_ordering CompareFloat(T lhs, T rhs) {
   return lhs_is_negative <=> rhs_is_negative;
 }
 
+bool Literal::operator==(const iceberg::Literal& other) const {
+  return (*this <=> other) == 0;
+}
+
 // Three-way comparison operator
 std::partial_ordering Literal::operator<=>(const Literal& other) const {
   // If types are different, comparison is unordered

src/iceberg/expression/literal.h

@@ -105,6 +105,8 @@ class ICEBERG_EXPORT Literal {
   /// was not valid
   Result<Literal> CastTo(const std::shared_ptr<PrimitiveType>& target_type) const;
 
+  bool operator==(const Literal& other) const;
+
   /// \brief Compare two PrimitiveLiterals. Both literals must have the same type
   /// and should not be AboveMax or BelowMin.
   std::partial_ordering operator<=>(const Literal& other) const;

src/iceberg/manifest_entry.cc

@@ -27,24 +27,6 @@
 
 namespace iceberg {
 
-bool DataFile::operator==(const iceberg::DataFile& other) const {
-  return content == other.content && file_path == other.file_path &&
-         file_format == other.file_format && partition <=> other.partition == 0 &&
-         record_count == other.record_count &&
-         file_size_in_bytes == other.file_size_in_bytes &&
-         column_sizes == other.column_sizes && value_counts == other.value_counts &&
-         null_value_counts == other.null_value_counts &&
-         nan_value_counts == other.nan_value_counts &&
-         lower_bounds == other.lower_bounds && upper_bounds == other.upper_bounds &&
-         key_metadata == other.key_metadata && split_offsets == other.split_offsets &&
-         equality_ids == other.equality_ids && sort_order_id == other.sort_order_id &&
-         partition_spec_id == other.partition_spec_id &&
-         first_row_id == other.first_row_id &&
-         referenced_data_file == other.referenced_data_file &&
-         content_offset == other.content_offset &&
-         content_size_in_bytes == other.content_size_in_bytes;
-}
-
 bool ManifestEntry::operator==(const iceberg::ManifestEntry& other) const {
   return status == other.status && snapshot_id == other.snapshot_id &&
              sequence_number == other.sequence_number &&

src/iceberg/manifest_entry.h

@@ -261,7 +261,7 @@ struct ICEBERG_EXPORT DataFile {
       SchemaField::MakeOptional(145, "content_size_in_bytes", iceberg::int64(),
                                 "The length of referenced content stored in the file");
 
-  bool operator==(const DataFile& other) const;
+  bool operator==(const DataFile& other) const = default;
 
   static std::shared_ptr<StructType> Type(std::shared_ptr<StructType> partition_type);
 };

src/iceberg/manifest_list.cc

@@ -23,29 +23,6 @@
 
 namespace iceberg {
 
-bool PartitionFieldSummary::operator==(
-    const iceberg::PartitionFieldSummary& other) const {
-  return contains_null == other.contains_null && contains_nan == other.contains_nan &&
-         lower_bound == other.lower_bound && upper_bound == other.upper_bound;
-}
-
-bool ManifestFile::operator==(const iceberg::ManifestFile& other) const {
-  return manifest_path == other.manifest_path &&
-         manifest_length == other.manifest_length &&
-         partition_spec_id == other.partition_spec_id && content == other.content &&
-         sequence_number == other.sequence_number &&
-         min_sequence_number == other.min_sequence_number &&
-         added_snapshot_id == other.added_snapshot_id &&
-         added_files_count == other.added_files_count &&
-         existing_files_count == other.existing_files_count &&
-         deleted_files_count == other.deleted_files_count &&
-         added_rows_count == other.added_rows_count &&
-         existing_rows_count == other.existing_rows_count &&
-         deleted_rows_count == other.deleted_rows_count &&
-         partitions == other.partitions && key_metadata == other.key_metadata &&
-         first_row_id == other.first_row_id;
-}
-
 const StructType& PartitionFieldSummary::Type() {
   static const StructType kInstance{{
       PartitionFieldSummary::kContainsNull,

src/iceberg/manifest_list.h

@@ -64,7 +64,7 @@ struct ICEBERG_EXPORT PartitionFieldSummary {
   inline static const SchemaField kUpperBound = SchemaField::MakeOptional(
       511, "upper_bound", iceberg::binary(), "Partition upper bound for all files");
 
-  bool operator==(const PartitionFieldSummary& other) const;
+  bool operator==(const PartitionFieldSummary& other) const = default;
 
   static const StructType& Type();
 };
@@ -190,7 +190,7 @@ struct ICEBERG_EXPORT ManifestFile {
       520, "first_row_id", iceberg::int64(),
       "Starting row ID to assign to new rows in ADDED data files");
 
-  bool operator==(const ManifestFile& other) const;
+  bool operator==(const ManifestFile& other) const = default;
 
   static const StructType& Type();
 };