enforce [[nodiscard]]

Signed-off-by: Junwang Zhao <[email protected]>

Author: zhjwpku

.clang-tidy

@@ -21,7 +21,6 @@ Checks: |
   clang-analyzer-*,
   google-*,
   modernize-*,
-  -modernize-use-nodiscard,
   -modernize-use-trailing-return-type,
 
 CheckOptions:

src/iceberg/arrow/demo_arrow.h

@@ -30,7 +30,7 @@ class ICEBERG_ARROW_EXPORT DemoArrow : public Table {
  public:
   DemoArrow() = default;
   ~DemoArrow() override = default;
-  std::string print() const override;
+  [[nodiscard]] std::string print() const override;
 };
 
 }  // namespace iceberg::arrow

src/iceberg/demo_table.h

@@ -28,7 +28,7 @@ class ICEBERG_EXPORT DemoTable : public Table {
   DemoTable() = default;
   ~DemoTable() override = default;
 
-  std::string print() const override;
+  [[nodiscard]] std::string print() const override;
 };
 
 }  // namespace iceberg

src/iceberg/puffin.h

@@ -28,7 +28,7 @@ namespace iceberg {
 class ICEBERG_EXPORT Puffin {
  public:
   virtual ~Puffin() = default;
-  virtual std::string print() const = 0;
+  [[nodiscard]] virtual std::string print() const = 0;
 };
 
 }  // namespace iceberg

src/iceberg/puffin/demo_puffin.h

@@ -28,7 +28,7 @@ class ICEBERG_PUFFIN_EXPORT DemoPuffin : public Puffin {
  public:
   DemoPuffin() = default;
   ~DemoPuffin() override = default;
-  std::string print() const override;
+  [[nodiscard]] std::string print() const override;
 };
 
 }  // namespace iceberg::puffin

src/iceberg/table.h

@@ -29,7 +29,7 @@ namespace iceberg {
 class ICEBERG_EXPORT Table {
  public:
   virtual ~Table() = default;
-  virtual std::string print() const = 0;
+  [[nodiscard]] virtual std::string print() const = 0;
 };
 
 }  // namespace iceberg