1

HeartLinked · HeartLinked · commit 2d159fd93fbb · 2025-12-02T18:37:40.000+08:00
diff --git a/src/iceberg/table_metadata.cc b/src/iceberg/table_metadata.cc
@@ -454,10 +454,8 @@ TableMetadataBuilder& TableMetadataBuilder::SetDefaultSortOrder(
 TableMetadataBuilder& TableMetadataBuilder::SetDefaultSortOrder(int32_t order_id) {
   if (order_id == -1) {
     if (!impl_->last_added_order_id.has_value()) {
-      errors_.emplace_back(
-          ErrorKind::kInvalidArgument,
-          "Cannot set last added sort order: no sort order has been added");
-      return *this;
+      return AddError(ErrorKind::kInvalidArgument,
+                      "Cannot set last added sort order: no sort order has been added");
     }
     return SetDefaultSortOrder(impl_->last_added_order_id.value());
   }

Original file line number	Diff line number	Diff line change
`@@ -454,10 +454,8 @@ TableMetadataBuilder& TableMetadataBuilder::SetDefaultSortOrder(`
`454`	`454`	`TableMetadataBuilder& TableMetadataBuilder::SetDefaultSortOrder(int32_t order_id) {`
`455`	`455`	`if (order_id == -1) {`
`456`	`456`	`if (!impl_->last_added_order_id.has_value()) {`
`457`		`- errors_.emplace_back(`
`458`		`- ErrorKind::kInvalidArgument,`
`459`		`- "Cannot set last added sort order: no sort order has been added");`
`460`		`- return *this;`
	`457`	`+ return AddError(ErrorKind::kInvalidArgument,`
	`458`	`+ "Cannot set last added sort order: no sort order has been added");`
`461`	`459`	`}`
`462`	`460`	`return SetDefaultSortOrder(impl_->last_added_order_id.value());`
`463`	`461`	`}`