Skip to content

Commit 2df1203

Browse files
HeartLinkedHeartLinked
committed
1.1
1 parent d27c8f4 commit 2df1203

File tree

1 file changed

+18
-19
lines changed

1 file changed

+18
-19
lines changed

‎src/iceberg/table_update.h‎

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,7 @@ class ICEBERG_EXPORT TableUpdate {
5858
/// provides information about the base metadata and operation mode.
5959
///
6060
/// \param context The context containing base metadata and operation state
61-
/// \return Status indicating success or failure with error details
62-
virtual Status GenerateRequirements(TableUpdateContext& context) const = 0;
61+
virtual void GenerateRequirements(TableUpdateContext& context) const = 0;
6362
};
6463

6564
namespace table {
@@ -73,7 +72,7 @@ class ICEBERG_EXPORT AssignUUID : public TableUpdate {
7372

7473
void ApplyTo(TableMetadataBuilder& builder) const override;
7574

76-
Status GenerateRequirements(TableUpdateContext& context) const override;
75+
void GenerateRequirements(TableUpdateContext& context) const override;
7776

7877
private:
7978
std::string uuid_;
@@ -89,7 +88,7 @@ class ICEBERG_EXPORT UpgradeFormatVersion : public TableUpdate {
8988

9089
void ApplyTo(TableMetadataBuilder& builder) const override;
9190

92-
Status GenerateRequirements(TableUpdateContext& context) const override;
91+
void GenerateRequirements(TableUpdateContext& context) const override;
9392

9493
private:
9594
int8_t format_version_;
@@ -107,7 +106,7 @@ class ICEBERG_EXPORT AddSchema : public TableUpdate {
107106

108107
void ApplyTo(TableMetadataBuilder& builder) const override;
109108

110-
Status GenerateRequirements(TableUpdateContext& context) const override;
109+
void GenerateRequirements(TableUpdateContext& context) const override;
111110

112111
private:
113112
std::shared_ptr<Schema> schema_;
@@ -123,7 +122,7 @@ class ICEBERG_EXPORT SetCurrentSchema : public TableUpdate {
123122

124123
void ApplyTo(TableMetadataBuilder& builder) const override;
125124

126-
Status GenerateRequirements(TableUpdateContext& context) const override;
125+
void GenerateRequirements(TableUpdateContext& context) const override;
127126

128127
private:
129128
int32_t schema_id_;
@@ -139,7 +138,7 @@ class ICEBERG_EXPORT AddPartitionSpec : public TableUpdate {
139138

140139
void ApplyTo(TableMetadataBuilder& builder) const override;
141140

142-
Status GenerateRequirements(TableUpdateContext& context) const override;
141+
void GenerateRequirements(TableUpdateContext& context) const override;
143142

144143
private:
145144
std::shared_ptr<PartitionSpec> spec_;
@@ -154,7 +153,7 @@ class ICEBERG_EXPORT SetDefaultPartitionSpec : public TableUpdate {
154153

155154
void ApplyTo(TableMetadataBuilder& builder) const override;
156155

157-
Status GenerateRequirements(TableUpdateContext& context) const override;
156+
void GenerateRequirements(TableUpdateContext& context) const override;
158157

159158
private:
160159
int32_t spec_id_;
@@ -170,7 +169,7 @@ class ICEBERG_EXPORT RemovePartitionSpecs : public TableUpdate {
170169

171170
void ApplyTo(TableMetadataBuilder& builder) const override;
172171

173-
Status GenerateRequirements(TableUpdateContext& context) const override;
172+
void GenerateRequirements(TableUpdateContext& context) const override;
174173

175174
private:
176175
std::vector<int32_t> spec_ids_;
@@ -186,7 +185,7 @@ class ICEBERG_EXPORT RemoveSchemas : public TableUpdate {
186185

187186
void ApplyTo(TableMetadataBuilder& builder) const override;
188187

189-
Status GenerateRequirements(TableUpdateContext& context) const override;
188+
void GenerateRequirements(TableUpdateContext& context) const override;
190189

191190
private:
192191
std::vector<int32_t> schema_ids_;
@@ -202,7 +201,7 @@ class ICEBERG_EXPORT AddSortOrder : public TableUpdate {
202201

203202
void ApplyTo(TableMetadataBuilder& builder) const override;
204203

205-
Status GenerateRequirements(TableUpdateContext& context) const override;
204+
void GenerateRequirements(TableUpdateContext& context) const override;
206205

207206
private:
208207
std::shared_ptr<SortOrder> sort_order_;
@@ -217,7 +216,7 @@ class ICEBERG_EXPORT SetDefaultSortOrder : public TableUpdate {
217216

218217
void ApplyTo(TableMetadataBuilder& builder) const override;
219218

220-
Status GenerateRequirements(TableUpdateContext& context) const override;
219+
void GenerateRequirements(TableUpdateContext& context) const override;
221220

222221
private:
223222
int32_t sort_order_id_;
@@ -233,7 +232,7 @@ class ICEBERG_EXPORT AddSnapshot : public TableUpdate {
233232

234233
void ApplyTo(TableMetadataBuilder& builder) const override;
235234

236-
Status GenerateRequirements(TableUpdateContext& context) const override;
235+
void GenerateRequirements(TableUpdateContext& context) const override;
237236

238237
private:
239238
std::shared_ptr<Snapshot> snapshot_;
@@ -249,7 +248,7 @@ class ICEBERG_EXPORT RemoveSnapshots : public TableUpdate {
249248

250249
void ApplyTo(TableMetadataBuilder& builder) const override;
251250

252-
Status GenerateRequirements(TableUpdateContext& context) const override;
251+
void GenerateRequirements(TableUpdateContext& context) const override;
253252

254253
private:
255254
std::vector<int64_t> snapshot_ids_;
@@ -264,7 +263,7 @@ class ICEBERG_EXPORT RemoveSnapshotRef : public TableUpdate {
264263

265264
void ApplyTo(TableMetadataBuilder& builder) const override;
266265

267-
Status GenerateRequirements(TableUpdateContext& context) const override;
266+
void GenerateRequirements(TableUpdateContext& context) const override;
268267

269268
private:
270269
std::string ref_name_;
@@ -297,7 +296,7 @@ class ICEBERG_EXPORT SetSnapshotRef : public TableUpdate {
297296

298297
void ApplyTo(TableMetadataBuilder& builder) const override;
299298

300-
Status GenerateRequirements(TableUpdateContext& context) const override;
299+
void GenerateRequirements(TableUpdateContext& context) const override;
301300

302301
private:
303302
std::string ref_name_;
@@ -318,7 +317,7 @@ class ICEBERG_EXPORT SetProperties : public TableUpdate {
318317

319318
void ApplyTo(TableMetadataBuilder& builder) const override;
320319

321-
Status GenerateRequirements(TableUpdateContext& context) const override;
320+
void GenerateRequirements(TableUpdateContext& context) const override;
322321

323322
private:
324323
std::unordered_map<std::string, std::string> updated_;
@@ -334,7 +333,7 @@ class ICEBERG_EXPORT RemoveProperties : public TableUpdate {
334333

335334
void ApplyTo(TableMetadataBuilder& builder) const override;
336335

337-
Status GenerateRequirements(TableUpdateContext& context) const override;
336+
void GenerateRequirements(TableUpdateContext& context) const override;
338337

339338
private:
340339
std::vector<std::string> removed_;
@@ -349,7 +348,7 @@ class ICEBERG_EXPORT SetLocation : public TableUpdate {
349348

350349
void ApplyTo(TableMetadataBuilder& builder) const override;
351350

352-
Status GenerateRequirements(TableUpdateContext& context) const override;
351+
void GenerateRequirements(TableUpdateContext& context) const override;
353352

354353
private:
355354
std::string location_;

0 commit comments

Comments
 (0)