Skip to content

Commit 30dceec

Browse files
committed
fix comments
1 parent 87b9c3f commit 30dceec

13 files changed

+153
-925
lines changed

src/iceberg/CMakeLists.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ set(ICEBERG_SOURCES
3131
manifest_entry.cc
3232
manifest_list.cc
3333
metadata_columns.cc
34-
metadata_update.cc
3534
name_mapping.cc
3635
partition_field.cc
3736
partition_spec.cc
@@ -56,8 +55,6 @@ set(ICEBERG_SOURCES
5655
manifest_reader_internal.cc
5756
manifest_writer.cc
5857
arrow_c_data_guard_internal.cc
59-
update_requirement.cc
60-
update_requirements.cc
6158
util/conversions.cc
6259
util/decimal.cc
6360
util/gzip_internal.cc

src/iceberg/catalog.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ class ICEBERG_EXPORT Catalog {
123123
/// \return a Table instance or ErrorKind::kAlreadyExists if the table already exists
124124
virtual Result<std::unique_ptr<Table>> UpdateTable(
125125
const TableIdentifier& identifier,
126-
const std::vector<std::unique_ptr<UpdateRequirement>>& requirements,
127-
const std::vector<std::unique_ptr<MetadataUpdate>>& updates) = 0;
126+
const std::vector<std::unique_ptr<TableRequirement>>& requirements,
127+
const std::vector<std::unique_ptr<TableUpdate>>& updates) = 0;
128128

129129
/// \brief Start a transaction to create a table
130130
///

src/iceberg/catalog/memory/in_memory_catalog.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -392,8 +392,8 @@ Result<std::unique_ptr<Table>> InMemoryCatalog::CreateTable(
392392

393393
Result<std::unique_ptr<Table>> InMemoryCatalog::UpdateTable(
394394
const TableIdentifier& identifier,
395-
const std::vector<std::unique_ptr<UpdateRequirement>>& requirements,
396-
const std::vector<std::unique_ptr<MetadataUpdate>>& updates) {
395+
const std::vector<std::unique_ptr<TableRequirement>>& requirements,
396+
const std::vector<std::unique_ptr<TableUpdate>>& updates) {
397397
return NotImplemented("update table");
398398
}
399399

src/iceberg/catalog/memory/in_memory_catalog.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ class ICEBERG_EXPORT InMemoryCatalog
7777

7878
Result<std::unique_ptr<Table>> UpdateTable(
7979
const TableIdentifier& identifier,
80-
const std::vector<std::unique_ptr<UpdateRequirement>>& requirements,
81-
const std::vector<std::unique_ptr<MetadataUpdate>>& updates) override;
80+
const std::vector<std::unique_ptr<TableRequirement>>& requirements,
81+
const std::vector<std::unique_ptr<TableUpdate>>& updates) override;
8282

8383
Result<std::shared_ptr<Transaction>> StageCreateTable(
8484
const TableIdentifier& identifier, const Schema& schema, const PartitionSpec& spec,

src/iceberg/metadata_update.cc

Lines changed: 0 additions & 285 deletions
This file was deleted.

0 commit comments

Comments
 (0)