Skip to content

Commit 356912a

Browse files
committed
2
1 parent 1dfc2ee commit 356912a

File tree

4 files changed

+21
-10
lines changed

4 files changed

+21
-10
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ jobs:
110110
runs-on: ubuntu-24.04
111111
CC: gcc-14
112112
CXX: g++-14
113+
meson-setup-args: -Drest_integration_test=enabled
113114
- title: AMD64 Windows 2025
114115
runs-on: windows-2025
115116
meson-setup-args: --vsenv

ci/scripts/build_iceberg.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ fi
4747

4848
cmake "${CMAKE_ARGS[@]}" ${source_dir}
4949
if is_windows; then
50-
cmake --build . --config Release --target install -j
50+
cmake --build . --config Release --target install
5151
ctest --output-on-failure -C Release
5252
else
53-
cmake --build . --target install -j
53+
cmake --build . --target install
5454
ctest --output-on-failure
5555
fi
5656

meson.options

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,12 @@ option(
3636
description: 'Build rest catalog client',
3737
value: 'enabled',
3838
)
39+
40+
option(
41+
'rest_integration_test',
42+
type: 'feature',
43+
description: 'Build integration test for rest catalog',
44+
value: 'disabled',
45+
)
46+
3947
option('tests', type: 'feature', description: 'Build tests', value: 'enabled')

src/iceberg/test/meson.build

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ configure_file(
2727
install_dir: get_option('includedir') / 'iceberg/test',
2828
)
2929

30-
# Add test utilities subdirectory
3130
subdir('util')
3231

3332
iceberg_tests = {
@@ -91,17 +90,20 @@ iceberg_tests = {
9190
}
9291

9392
if get_option('rest').enabled()
94-
cpp_httplib_dep = dependency('cpp-httplib')
9593
iceberg_tests += {
9694
'rest_catalog_test': {
97-
'sources': files(
98-
'rest_catalog_test.cc',
99-
'rest_json_internal_test.cc',
100-
'rest_util_test.cc',
101-
),
102-
'dependencies': [iceberg_rest_dep, cpp_httplib_dep],
95+
'sources': files('rest_json_internal_test.cc', 'rest_util_test.cc'),
96+
'dependencies': [iceberg_rest_dep],
10397
},
10498
}
99+
if get_option('rest_integration_test').enabled()
100+
iceberg_tests += {
101+
'rest_integration_test': {
102+
'sources': files('rest_catalog_test.cc'),
103+
'dependencies': [iceberg_rest_dep],
104+
},
105+
}
106+
endif
105107
endif
106108

107109
foreach test_name, values : iceberg_tests

0 commit comments

Comments
 (0)