update

Author: HeartLinked

src/iceberg/catalog/rest/meson.build

@@ -33,6 +33,7 @@ iceberg_rest_lib = library(
     'iceberg_rest',
     sources: iceberg_rest_sources,
     dependencies: iceberg_rest_build_deps,
+    cpp_args: iceberg_common_cpp_args,
     gnu_symbol_visibility: 'hidden',
     cpp_shared_args: ['-DICEBERG_REST_EXPORTING'],
     cpp_static_args: ['-DICEBERG_REST_STATIC'],

src/iceberg/meson.build

@@ -15,6 +15,12 @@
 # specific language governing permissions and limitations
 # under the License.
 
+cpp = meson.get_compiler('cpp')
+iceberg_common_cpp_args = []
+if cpp.get_id() == 'msvc'
+    iceberg_common_cpp_args += cpp.get_supported_arguments(['/bigobj'])
+endif
+
 conf_data = configuration_data()
 version = meson.project_version()
 components = version.split('.')
@@ -121,6 +127,7 @@ iceberg_lib = library(
     dependencies: iceberg_deps,
     include_directories: iceberg_include_dir,
     install: true,
+    cpp_args: iceberg_common_cpp_args,
     gnu_symbol_visibility: 'inlineshidden',
     cpp_shared_args: ['-DICEBERG_EXPORTING'],
     cpp_static_args: ['-DICEBERG_STATIC'],

src/iceberg/test/meson.build

@@ -104,6 +104,7 @@ foreach test_name, values : iceberg_tests
             'dependencies',
             [],
         ),
+        cpp_args: iceberg_common_cpp_args,
     )
     test(test_name, exc)
 endforeach

src/iceberg/test/rest_json_internal_test.cc

@@ -940,7 +940,6 @@ INSTANTIATE_TEST_SUITE_P(
       return info.param.test_name;
     });
 
-// ErrorModel tests - testing the nested error model structure
 DECLARE_INVALID_TEST(ErrorModel)
 
 INSTANTIATE_TEST_SUITE_P(