refactor: add a manifest dir to hold all manifest related files (#372)

Improve code organization by collecting manifest-related files into a
dedicate directory. Writer helpers are renamed with _internal.h suffix
to prevent installation, keeping the public API clean.

Author: zhjwpku

src/iceberg/CMakeLists.txt

@@ -33,12 +33,15 @@ set(ICEBERG_SOURCES
     file_writer.cc
     inheritable_metadata.cc
     json_internal.cc
-    manifest_adapter.cc
-    manifest_entry.cc
-    manifest_list.cc
-    manifest_reader.cc
-    manifest_reader_internal.cc
-    manifest_writer.cc
+    manifest/manifest_adapter.cc
+    manifest/manifest_entry.cc
+    manifest/manifest_list.cc
+    manifest/manifest_reader.cc
+    manifest/manifest_reader_internal.cc
+    manifest/manifest_writer.cc
+    manifest/v1_metadata.cc
+    manifest/v2_metadata.cc
+    manifest/v3_metadata.cc
     metadata_columns.cc
     name_mapping.cc
     partition_field.cc
@@ -74,10 +77,7 @@ set(ICEBERG_SOURCES
     util/temporal_util.cc
     util/timepoint.cc
     util/truncate_util.cc
-    util/uuid.cc
-    v1_metadata.cc
-    v2_metadata.cc
-    v3_metadata.cc)
+    util/uuid.cc)
 
 set(ICEBERG_STATIC_BUILD_INTERFACE_LIBS)
 set(ICEBERG_SHARED_BUILD_INTERFACE_LIBS)
@@ -131,6 +131,7 @@ iceberg_install_all_headers(iceberg)
 
 add_subdirectory(catalog)
 add_subdirectory(expression)
+add_subdirectory(manifest)
 add_subdirectory(row)
 add_subdirectory(util)
 

src/iceberg/inheritable_metadata.cc

@@ -23,8 +23,8 @@
 
 #include <iceberg/result.h>
 
-#include "iceberg/manifest_entry.h"
-#include "iceberg/manifest_list.h"
+#include "iceberg/manifest/manifest_entry.h"
+#include "iceberg/manifest/manifest_list.h"
 #include "iceberg/snapshot.h"
 
 namespace iceberg {

src/iceberg/manifest/CMakeLists.txt

@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+iceberg_install_all_headers(iceberg/manifest)

src/iceberg/manifest_adapter.cc src/iceberg/manifest/manifest_adapter.ccsrc/iceberg/manifest_adapter.cc renamed to src/iceberg/manifest/manifest_adapter.cc

@@ -17,16 +17,15 @@
  * under the License.
  */
 
-#include "iceberg/manifest_adapter.h"
-
 #include <memory>
 #include <utility>
 
 #include <nanoarrow/nanoarrow.h>
 
 #include "iceberg/arrow/nanoarrow_status_internal.h"
-#include "iceberg/manifest_entry.h"
-#include "iceberg/manifest_list.h"
+#include "iceberg/manifest/manifest_adapter_internal.h"
+#include "iceberg/manifest/manifest_entry.h"
+#include "iceberg/manifest/manifest_list.h"
 #include "iceberg/result.h"
 #include "iceberg/schema.h"
 #include "iceberg/util/checked_cast.h"

src/iceberg/manifest_adapter.h …erg/manifest/manifest_adapter_internal.hsrc/iceberg/manifest_adapter.h renamed to src/iceberg/manifest/manifest_adapter_internal.h src/iceberg/manifest_adapter.h renamed to src/iceberg/manifest/manifest_adapter_internal.h

@@ -19,7 +19,7 @@
 
 #pragma once
 
-/// \file iceberg/manifest_adapter.h
+/// \file iceberg/manifest/manifest_adapter_internal.h
 /// Base class for adapters handling v1/v2/v3/v4 manifest metadata.
 
 #include <memory>

src/iceberg/manifest_entry.cc src/iceberg/manifest/manifest_entry.ccsrc/iceberg/manifest_entry.cc renamed to src/iceberg/manifest/manifest_entry.cc

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-#include "iceberg/manifest_entry.h"
+#include "iceberg/manifest/manifest_entry.h"
 
 #include <memory>
 #include <vector>

src/iceberg/manifest_entry.h src/iceberg/manifest/manifest_entry.hsrc/iceberg/manifest_entry.h renamed to src/iceberg/manifest/manifest_entry.h

@@ -19,6 +19,8 @@
 
 #pragma once
 
+/// \file iceberg/manifest/manifest_entry.h
+
 #include <cstdint>
 #include <map>
 #include <memory>

src/iceberg/manifest_list.cc src/iceberg/manifest/manifest_list.ccsrc/iceberg/manifest_list.cc renamed to src/iceberg/manifest/manifest_list.cc

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-#include "iceberg/manifest_list.h"
+#include "iceberg/manifest/manifest_list.h"
 
 #include "iceberg/schema.h"
 

src/iceberg/manifest_list.h src/iceberg/manifest/manifest_list.hsrc/iceberg/manifest_list.h renamed to src/iceberg/manifest/manifest_list.h

@@ -19,7 +19,7 @@
 
 #pragma once
 
-/// \file iceberg/manifest_list.h
+/// \file iceberg/manifest/manifest_list.h
 
 #include <cstdint>
 #include <optional>

src/iceberg/manifest_reader.cc src/iceberg/manifest/manifest_reader.ccsrc/iceberg/manifest_reader.cc renamed to src/iceberg/manifest/manifest_reader.cc

@@ -17,11 +17,11 @@
  * under the License.
  */
 
-#include "iceberg/manifest_reader.h"
+#include "iceberg/manifest/manifest_reader.h"
 
-#include "iceberg/manifest_entry.h"
-#include "iceberg/manifest_list.h"
-#include "iceberg/manifest_reader_internal.h"
+#include "iceberg/manifest/manifest_entry.h"
+#include "iceberg/manifest/manifest_list.h"
+#include "iceberg/manifest/manifest_reader_internal.h"
 #include "iceberg/schema.h"
 #include "iceberg/schema_internal.h"
 #include "iceberg/type.h"