Skip to content

Commit 3752513

Browse files
committed
update rc.yml
1 parent d756319 commit 3752513

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/rc.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ on:
2020
push:
2121
tags:
2222
- '*-rc*'
23-
pull_request:
2423

2524
concurrency:
2625
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
@@ -32,7 +31,7 @@ jobs:
3231
archive:
3332
name: Archive
3433
runs-on: ubuntu-latest
35-
timeout-minutes: 5
34+
timeout-minutes: 5 # Can be reduced as we are not checking out submodules
3635
steps:
3736
- name: Checkout
3837
uses: actions/checkout@v4
@@ -49,7 +48,6 @@ jobs:
4948
echo "VERSION=${version}"
5049
echo "RC=${rc}"
5150
52-
5351
- name: Archive
5452
run: |
5553
id="apache-iceberg-cpp-${VERSION}-rc${RC}"
@@ -80,6 +78,8 @@ jobs:
8078
os:
8179
- macos-latest
8280
- ubuntu-latest
81+
# Consider adding windows-latest if your project supports it
82+
# - windows-latest
8383
steps:
8484
- name: Install C++ Build Tools (Ubuntu)
8585
if: runner.os == 'Linux'
@@ -112,6 +112,8 @@ jobs:
112112
fi
113113
echo "VERSION=${version}"
114114
echo "RC=${rc}"
115+
# You MUST create this verify_rc.sh script for C++
116+
# It should untar, cmake, build, and run tests (ctest)
115117
dev/release/verify_rc.sh "${version}" "${rc}"
116118
env:
117119
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)