Skip to content

Commit 3b393e3

Browse files
authored
fix: clang-tidy in cpplint should compile header files in C++23 (#367)
1 parent b1384a1 commit 3b393e3

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.github/workflows/cpp-linter.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ on:
2929
jobs:
3030
cpp-linter:
3131
runs-on: ubuntu-24.04
32+
permissions:
33+
contents: read
34+
pull-requests: write
3235
steps:
3336
- name: Checkout iceberg-cpp
3437
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
@@ -57,8 +60,9 @@ jobs:
5760
thread-comments: true
5861
ignore: 'build|cmake_modules|ci'
5962
database: build
63+
verbosity: 'debug'
6064
# need '-fno-builtin-std-forward_like', see https://github.com/llvm/llvm-project/issues/101614
61-
extra-args: '-I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like'
65+
extra-args: '-std=c++23 -I$PWD/src -I$PWD/build/src -fno-builtin-std-forward_like'
6266
- name: Fail fast?!
6367
if: steps.linter.outputs.checks-failed != 0
6468
run: |

0 commit comments

Comments
 (0)