Skip to content

Commit 3cb4759

Browse files
author
xiao.dong
committed
feat: add inclusive metrics evaluator
1 parent ad14e5a commit 3cb4759

File tree

5 files changed

+621
-1
lines changed

5 files changed

+621
-1
lines changed

src/iceberg/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ set(ICEBERG_SOURCES
2727
expression/literal.cc
2828
expression/predicate.cc
2929
expression/rewrite_not.cc
30+
expression/inclusive_metrics_evaluator.cc
3031
expression/term.cc
3132
file_reader.cc
3233
file_writer.cc

src/iceberg/expression/expression_visitor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ class ICEBERG_EXPORT BoundVisitor : public ExpressionVisitor<R> {
245245
/// Bound visitors do not support unbound predicates.
246246
///
247247
/// \param pred The unbound predicate
248-
Result<R> Predicate(const std::shared_ptr<UnboundPredicate>& pred) final {
248+
Result<R> Predicate(const std::shared_ptr<UnboundPredicate>& pred) override {
249249
ICEBERG_DCHECK(pred != nullptr, "UnboundPredicate cannot be null");
250250
return NotSupported("Not a bound predicate: {}", pred->ToString());
251251
}

0 commit comments

Comments
 (0)