ci: enable sanitizer

Author: wgtmac

.github/workflows/sanitizer_test.yml

@@ -50,9 +50,9 @@ jobs:
       - name: Run Tests
         working-directory: build
         env:
-          ASAN_OPTIONS: log_path=out.log:detect_leaks=1:symbolize=1:strict_string_checks=1:halt_on_error=0:detect_container_overflow=0
+          ASAN_OPTIONS: log_path=out.log:detect_leaks=1:symbolize=1:strict_string_checks=1:halt_on_error=1:detect_container_overflow=0
           LSAN_OPTIONS: suppressions=${{ github.workspace }}/.github/lsan-suppressions.txt
-          UBSAN_OPTIONS: log_path=out.log:halt_on_error=0:print_stacktrace=1:suppressions=${{ github.workspace }}/.github/ubsan-suppressions.txt
+          UBSAN_OPTIONS: log_path=out.log:halt_on_error=1:print_stacktrace=1:suppressions=${{ github.workspace }}/.github/ubsan-suppressions.txt
         run: |
           ctest --output-on-failure
       - name: Save the test output

cmake_modules/IcebergBuildUtils.cmake

@@ -147,9 +147,6 @@ function(add_iceberg_lib LIB_NAME)
                                  "$<INSTALL_INTERFACE:${ARG_SHARED_INSTALL_INTERFACE_LIBS}>"
                           PRIVATE ${ARG_SHARED_PRIVATE_LINK_LIBS})
 
-    target_link_libraries(${LIB_NAME}_shared
-                          PUBLIC "$<BUILD_INTERFACE:iceberg_sanitizer_flags>")
-
     install(TARGETS ${LIB_NAME}_shared
             EXPORT iceberg_targets
             ARCHIVE DESTINATION ${INSTALL_ARCHIVE_DIR}
@@ -205,9 +202,6 @@ function(add_iceberg_lib LIB_NAME)
                             PUBLIC "$<BUILD_INTERFACE:${ARG_STATIC_LINK_LIBS}>")
     endif()
 
-    target_link_libraries(${LIB_NAME}_static
-                          PUBLIC "$<BUILD_INTERFACE:iceberg_sanitizer_flags>")
-
     install(TARGETS ${LIB_NAME}_static
             EXPORT iceberg_targets
             ARCHIVE DESTINATION ${INSTALL_ARCHIVE_DIR}

cmake_modules/IcebergSanitizer.cmake

@@ -15,13 +15,9 @@
 # specific language governing permissions and limitations
 # under the License.
 
-add_library(iceberg_sanitizer_flags INTERFACE)
-
 if(ICEBERG_ENABLE_ASAN)
   if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
-    target_compile_options(iceberg_sanitizer_flags INTERFACE -fsanitize=address
-                                                             -fno-omit-frame-pointer)
-    target_link_options(iceberg_sanitizer_flags INTERFACE -fsanitize=address)
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address")
     message(STATUS "Address Sanitizer enabled")
   else()
     message(WARNING "Address Sanitizer is only supported for GCC and Clang compilers")
@@ -30,9 +26,7 @@ endif()
 
 if(ICEBERG_ENABLE_UBSAN)
   if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
-    target_compile_options(iceberg_sanitizer_flags INTERFACE -fsanitize=undefined
-                                                             -fno-omit-frame-pointer)
-    target_link_options(iceberg_sanitizer_flags INTERFACE -fsanitize=undefined)
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined")
     message(STATUS "Undefined Behavior Sanitizer enabled")
   else()
     message(WARNING "Undefined Behavior Sanitizer is only supported for GCC and Clang compilers"