temporarily disable sparrow to fix windows ci

Author: wgtmac

cmake_modules/IcebergThirdpartyToolchain.cmake

@@ -273,4 +273,4 @@ function(resolve_sparrow_dependency)
       PARENT_SCOPE)
 endfunction()
 
-resolve_sparrow_dependency()
+# resolve_sparrow_dependency()

src/iceberg/CMakeLists.txt

@@ -27,10 +27,14 @@ set(ICEBERG_SHARED_BUILD_INTERFACE_LIBS)
 set(ICEBERG_STATIC_INSTALL_INTERFACE_LIBS)
 set(ICEBERG_SHARED_INSTALL_INTERFACE_LIBS)
 
-list(APPEND ICEBERG_STATIC_BUILD_INTERFACE_LIBS nanoarrow::nanoarrow sparrow)
-list(APPEND ICEBERG_SHARED_BUILD_INTERFACE_LIBS nanoarrow::nanoarrow sparrow)
-list(APPEND ICEBERG_STATIC_INSTALL_INTERFACE_LIBS "Iceberg::nanoarrow" "Iceberg::sparrow")
-list(APPEND ICEBERG_SHARED_INSTALL_INTERFACE_LIBS "Iceberg::nanoarrow" "Iceberg::sparrow")
+# list(APPEND ICEBERG_STATIC_BUILD_INTERFACE_LIBS nanoarrow::nanoarrow sparrow)
+# list(APPEND ICEBERG_SHARED_BUILD_INTERFACE_LIBS nanoarrow::nanoarrow sparrow)
+# list(APPEND ICEBERG_STATIC_INSTALL_INTERFACE_LIBS "Iceberg::nanoarrow" "Iceberg::sparrow")
+# list(APPEND ICEBERG_SHARED_INSTALL_INTERFACE_LIBS "Iceberg::nanoarrow" "Iceberg::sparrow")
+list(APPEND ICEBERG_STATIC_BUILD_INTERFACE_LIBS nanoarrow::nanoarrow)
+list(APPEND ICEBERG_SHARED_BUILD_INTERFACE_LIBS nanoarrow::nanoarrow)
+list(APPEND ICEBERG_STATIC_INSTALL_INTERFACE_LIBS "Iceberg::nanoarrow")
+list(APPEND ICEBERG_SHARED_INSTALL_INTERFACE_LIBS "Iceberg::nanoarrow")
 
 add_iceberg_lib(iceberg
                 SOURCES

src/iceberg/arrow_c_data_internal.cc

@@ -24,7 +24,7 @@
 #include <tuple>
 #include <vector>
 
-#include <sparrow/builder/builder.hpp>
+// #include <sparrow/builder/builder.hpp>
 
 namespace iceberg::internal {
 
@@ -76,24 +76,24 @@ std::pair<ArrowSchema, ArrowArray> CreateExampleArrowSchemaAndArrayByNanoarrow()
   return {out_schema, out_array};
 }
 
-std::pair<ArrowSchema, ArrowArray> CreateExampleArrowSchemaAndArrayBySparrow() {
-  using struct_type = std::tuple<int64_t, sparrow::nullable<std::string>>;
-  std::vector<struct_type> values = {
-      {1, "a"},
-      {2, "b"},
-      {3, "c"},
-  };
-  auto sparrow_array = sparrow::build(values);
-
-  // Demonstrate the use of arrow_proxy to modify the schema
-  auto [_, non_owning_schema] = sparrow::get_arrow_structures(sparrow_array);
-  non_owning_schema->children[0]->name = "id";
-  non_owning_schema->children[0]->flags &= ~ARROW_FLAG_NULLABLE;
-  non_owning_schema->children[1]->name = "name";
-  non_owning_schema->children[1]->flags |= ARROW_FLAG_NULLABLE;
-
-  auto [array, schema] = sparrow::extract_arrow_structures(std::move(sparrow_array));
-  return {schema, array};
-}
+// std::pair<ArrowSchema, ArrowArray> CreateExampleArrowSchemaAndArrayBySparrow() {
+//   using struct_type = std::tuple<int64_t, sparrow::nullable<std::string>>;
+//   std::vector<struct_type> values = {
+//       {1, "a"},
+//       {2, "b"},
+//       {3, "c"},
+//   };
+//   auto sparrow_array = sparrow::build(values);
+
+//   // Demonstrate the use of arrow_proxy to modify the schema
+//   auto [_, non_owning_schema] = sparrow::get_arrow_structures(sparrow_array);
+//   non_owning_schema->children[0]->name = "id";
+//   non_owning_schema->children[0]->flags &= ~ARROW_FLAG_NULLABLE;
+//   non_owning_schema->children[1]->name = "name";
+//   non_owning_schema->children[1]->flags |= ARROW_FLAG_NULLABLE;
+
+//   auto [array, schema] = sparrow::extract_arrow_structures(std::move(sparrow_array));
+//   return {schema, array};
+// }
 
 }  // namespace iceberg::internal

src/iceberg/arrow_c_data_internal.h

@@ -20,7 +20,7 @@
 #pragma once
 
 #include <nanoarrow/nanoarrow.hpp>
-#include <sparrow/sparrow.hpp>
+// #include <sparrow/sparrow.hpp>
 
 namespace iceberg::internal {
 
@@ -31,11 +31,11 @@ namespace iceberg::internal {
  */
 std::pair<ArrowSchema, ArrowArray> CreateExampleArrowSchemaAndArrayByNanoarrow();
 
-/**
- * @brief Create a simple ArrowArray with non-nullable int64 and nullable string fields
- *
- * This is the example code to demonstrate the usage of sparrow API.
- */
-std::pair<ArrowSchema, ArrowArray> CreateExampleArrowSchemaAndArrayBySparrow();
+// /**
+//  * @brief Create a simple ArrowArray with non-nullable int64 and nullable string fields
+//  *
+//  * This is the example code to demonstrate the usage of sparrow API.
+//  */
+// std::pair<ArrowSchema, ArrowArray> CreateExampleArrowSchemaAndArrayBySparrow();
 
 }  // namespace iceberg::internal

test/arrow/arrow_test.cc

@@ -66,9 +66,9 @@ TEST(ArrowCDataTest, CheckArrowSchemaAndArrayByNanoarrow) {
   CheckArrowSchemaAndArray(&schema, &array);
 }
 
-TEST(ArrowCDataTest, CheckArrowSchemaAndArrayBySparrow) {
-  auto [schema, array] = internal::CreateExampleArrowSchemaAndArrayBySparrow();
-  CheckArrowSchemaAndArray(&schema, &array);
-}
+// TEST(ArrowCDataTest, CheckArrowSchemaAndArrayBySparrow) {
+//   auto [schema, array] = internal::CreateExampleArrowSchemaAndArrayBySparrow();
+//   CheckArrowSchemaAndArray(&schema, &array);
+// }
 
 }  // namespace iceberg