Skip to content

Commit 4b907f9

Browse files
committed
add components
1 parent 535c2e3 commit 4b907f9

File tree

10 files changed

+179
-333
lines changed

10 files changed

+179
-333
lines changed

CMakeLists.txt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,20 +48,16 @@ set(ICEBERG_DEPENDENCY_SOURCE "AUTO" CACHE STRING "Method to use for acquiring b
4848
set_property(CACHE ICEBERG_DEPENDENCY_SOURCE PROPERTY STRINGS "AUTO" "VENDOR" "SYSTEM")
4949
option(ICEBERG_ARROW "Build Arrow" ON)
5050

51-
include(CMakePackageConfigHelpers)
52-
include(CMakeParseArguments)
53-
include(BuildUtils)
54-
include(ExternalProject)
55-
include(FindPackageHandleStandardArgs)
5651
include(GNUInstallDirs)
57-
5852
set(ICEBERG_API_DIR "${CMAKE_SOURCE_DIR}/api")
5953
set(ICEBERG_INSTALL_LIBDIR "${CMAKE_INSTALL_LIBDIR}")
6054
set(ICEBERG_INSTALL_BINDIR "${CMAKE_INSTALL_BINDIR}")
6155
set(ICEBERG_INSTALL_INCLUDEDIR "${CMAKE_INSTALL_INCLUDEDIR}")
6256
set(ICEBERG_INSTALL_CMAKEDIR "${CMAKE_INSTALL_LIBDIR}/cmake")
6357
set(ICEBERG_INSTALL_DOCDIR "share/doc/${PROJECT_NAME}")
6458

59+
include(CMakeParseArguments)
60+
include(BuildUtils)
6561
include(ThirdpartyToolchain)
6662

6763
add_subdirectory(api)

cmake_modules/BuildUtils.cmake

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -18,30 +18,11 @@
1818
# Borrowed the file from Apache Arrow:
1919
# https://github.com/apache/arrow/blob/main/cpp/cmake_modules/BuildUtils.cmake
2020

21-
function(iceberg_install_cmake_package PACKAGE_NAME EXPORT_NAME)
22-
set(CONFIG_CMAKE "${PACKAGE_NAME}Config.cmake")
23-
set(BUILT_CONFIG_CMAKE "${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_CMAKE}")
24-
configure_package_config_file("${CONFIG_CMAKE}.in" "${BUILT_CONFIG_CMAKE}"
25-
INSTALL_DESTINATION "${ICEBERG_INSTALL_CMAKEDIR}/${PACKAGE_NAME}")
26-
set(CONFIG_VERSION_CMAKE "${PACKAGE_NAME}ConfigVersion.cmake")
27-
set(BUILT_CONFIG_VERSION_CMAKE "${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_VERSION_CMAKE}")
28-
write_basic_package_version_file("${BUILT_CONFIG_VERSION_CMAKE}"
29-
COMPATIBILITY SameMajorVersion)
30-
install(FILES "${BUILT_CONFIG_CMAKE}" "${BUILT_CONFIG_VERSION_CMAKE}"
31-
DESTINATION "${ICEBERG_INSTALL_CMAKEDIR}/${PACKAGE_NAME}")
32-
set(TARGETS_CMAKE "${PACKAGE_NAME}Targets.cmake")
33-
install(EXPORT ${EXPORT_NAME}
34-
DESTINATION "${ICEBERG_INSTALL_CMAKEDIR}/${PACKAGE_NAME}"
35-
NAMESPACE "${PACKAGE_NAME}::"
36-
FILE "${TARGETS_CMAKE}")
37-
endfunction()
38-
3921
function(ADD_ICEBERG_LIB LIB_NAME)
4022
set(options)
4123
set(one_value_args
4224
BUILD_SHARED
4325
BUILD_STATIC
44-
CMAKE_PACKAGE_NAME
4526
INSTALL_ARCHIVE_DIR
4627
INSTALL_LIBRARY_DIR
4728
INSTALL_RUNTIME_DIR
@@ -209,14 +190,12 @@ function(ADD_ICEBERG_LIB LIB_NAME)
209190
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
210191
endif()
211192

212-
if(ARG_CMAKE_PACKAGE_NAME)
213-
string(REPLACE "_" "-" LIB_NAME_DASHED ${LIB_NAME})
214-
set(TARGETS_CMAKE "${LIB_NAME_DASHED}-targets.cmake")
215-
install(EXPORT ${LIB_NAME}_targets
216-
DESTINATION "${ICEBERG_INSTALL_CMAKEDIR}/${ARG_CMAKE_PACKAGE_NAME}"
217-
NAMESPACE Iceberg::
218-
FILE "${TARGETS_CMAKE}")
219-
endif()
193+
string(TOLOWER ${LIB_NAME} LIB_NAME_LOWER_CASE)
194+
string(REPLACE "_" "-" LIB_NAME_DASH_SEPARATED_LOWER_CASE ${LIB_NAME_LOWER_CASE})
195+
install(EXPORT ${LIB_NAME}_targets
196+
DESTINATION "${ICEBERG_INSTALL_CMAKEDIR}/Iceberg"
197+
NAMESPACE "Iceberg::"
198+
FILE "${LIB_NAME_DASH_SEPARATED_LOWER_CASE}-targets.cmake")
220199

221200
# Modify variable in calling scope
222201
if(ARG_OUTPUTS)

cmake_modules/FindArrowAlt.cmake

Lines changed: 0 additions & 75 deletions
This file was deleted.

0 commit comments

Comments
 (0)