fix: review comments

Author: zhjwpku

src/iceberg/util/decimal.cc

@@ -24,21 +24,18 @@
 
 #include "iceberg/util/decimal.h"
 
-#include <array>
 #include <bit>
 #include <charconv>
 #include <climits>
 #include <cmath>
-#include <cstdint>
 #include <cstring>
 #include <format>
 #include <iomanip>
 #include <limits>
 #include <sstream>
-#include <string>
-#include <string_view>
 #include <utility>
 
+#include "iceberg/exception.h"
 #include "iceberg/result.h"
 #include "iceberg/util/int128.h"
 #include "iceberg/util/macros.h"
@@ -287,9 +284,8 @@ bool RescaleWouldCauseDataLoss(const Decimal& value, int32_t delta_scale,
 Decimal::Decimal(std::string_view str) {
   auto result = Decimal::FromString(str);
   if (!result) {
-    throw std::runtime_error(
-        std::format("Failed to parse Decimal from string: {}, error: {}", str,
-                    result.error().message));
+    throw IcebergError(std::format("Failed to parse Decimal from string: {}, error: {}",
+                                   str, result.error().message));
   }
   *this = std::move(result.value());
 }

src/iceberg/util/decimal.h

@@ -52,18 +52,18 @@ class ICEBERG_EXPORT Decimal : public util::Formattable {
   constexpr Decimal() noexcept = default;
 
   /// \brief Create a Decimal from a 128-bit integer.
-  constexpr Decimal(int128_t value) noexcept  // NOLINT(google-explicit-constructor)
+  constexpr Decimal(int128_t value) noexcept  // NOLINT implicit conversion
       : data_(value) {}
 
   /// \brief Create a Decimal from any integer not wider than 64 bits.
   template <typename T>
     requires(std::is_integral_v<T> && (sizeof(T) <= sizeof(uint64_t)))
-  constexpr Decimal(T value) noexcept  // NOLINT(google-explicit-constructor)
-  {
-    data_ = static_cast<int128_t>(value);
-  }
+  constexpr Decimal(T value) noexcept  // NOLINT implicit conversion
+      : data_(static_cast<int128_t>(value)) {}
 
   /// \brief Parse a Decimal from a string representation.
+  /// \throw This constructor throws an exception if parsing fails. Use
+  /// Decimal::FromString() if you want to handle errors more gracefully.
   explicit Decimal(std::string_view str);
 
   /// \brief Create a Decimal from two 64-bit integers.