Skip to content

Commit 58d926f

Browse files
authored
refactor: enhance forward declarations in type_fwd.h (#187)
Enhanced the forward declaration system in `type_fwd.h` to reduce compilation dependencies and improve build times. ## Changes Made - Added missing forward declarations for commonly used classes - Reorganized declarations into logical groups with descriptive comments - Removed outdated TODO comment regarding (These classes were already properly declared): - `StructLike` - `MetadataUpdate` - `UpdateRequirement` - `AppendFiles`
1 parent 923a976 commit 58d926f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/iceberg/type_fwd.h

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,11 @@ enum class SnapshotRefType;
115115
enum class TransformType;
116116

117117
class Expression;
118+
class Literal;
118119

120+
class DataTableScan;
119121
class FileScanTask;
122+
class ScanTask;
120123
class TableScan;
121124
class TableScanBuilder;
122125

@@ -125,18 +128,17 @@ struct ManifestEntry;
125128
struct ManifestFile;
126129
struct ManifestList;
127130

128-
class ManifestReader;
129131
class ManifestListReader;
132+
class ManifestListWriter;
133+
class ManifestReader;
134+
class ManifestWriter;
130135

131-
/// ----------------------------------------------------------------------------
132-
/// TODO: Forward declarations below are not added yet.
133-
/// ----------------------------------------------------------------------------
136+
class Reader;
137+
class Writer;
134138

135139
class StructLike;
136-
137140
class MetadataUpdate;
138141
class UpdateRequirement;
139-
140142
class AppendFiles;
141143

142144
} // namespace iceberg

0 commit comments

Comments
 (0)