chore: don't include expected.h but result.h (#69)

It is suggested that we include result.h instead of expected.h so that
in the future we can simply replace this ported iceberg::expected with
std::expected.

Besides that, I fix some IWYU warning in this PR.

Author: zhjwpku

src/iceberg/arrow/arrow_error_transform_internal.h

@@ -22,7 +22,6 @@
 #include <arrow/result.h>
 #include <arrow/status.h>
 
-#include "iceberg/expected.h"
 #include "iceberg/result.h"
 
 namespace iceberg::arrow {

src/iceberg/json_internal.cc

@@ -24,15 +24,14 @@
 
 #include <nlohmann/json.hpp>
 
-#include "iceberg/expected.h"
 #include "iceberg/partition_spec.h"
 #include "iceberg/result.h"
 #include "iceberg/schema.h"
 #include "iceberg/schema_internal.h"
 #include "iceberg/sort_order.h"
 #include "iceberg/transform.h"
 #include "iceberg/type.h"
-#include "iceberg/util/formatter.h"
+#include "iceberg/util/formatter.h"  // IWYU pragma: keep
 #include "iceberg/util/macros.h"
 
 namespace iceberg {

src/iceberg/json_internal.h

@@ -20,11 +20,9 @@
 #pragma once
 
 #include <memory>
-#include <string_view>
 
 #include <nlohmann/json_fwd.hpp>
 
-#include "iceberg/expected.h"
 #include "iceberg/result.h"
 #include "iceberg/type_fwd.h"
 

src/iceberg/partition_field.cc

@@ -23,7 +23,7 @@
 
 #include "iceberg/transform.h"
 #include "iceberg/type.h"
-#include "iceberg/util/formatter.h"
+#include "iceberg/util/formatter.h"  // IWYU pragma: keep
 
 namespace iceberg {
 

src/iceberg/partition_field.h

@@ -26,7 +26,6 @@
 #include <memory>
 #include <string>
 #include <string_view>
-#include <vector>
 
 #include "iceberg/iceberg_export.h"
 #include "iceberg/type_fwd.h"

src/iceberg/partition_spec.cc

@@ -23,7 +23,7 @@
 
 #include "iceberg/schema.h"
 #include "iceberg/type.h"
-#include "iceberg/util/formatter.h"
+#include "iceberg/util/formatter.h"  // IWYU pragma: keep
 
 namespace iceberg {
 

src/iceberg/schema_field.cc

@@ -22,7 +22,7 @@
 #include <format>
 
 #include "iceberg/type.h"
-#include "iceberg/util/formatter.h"
+#include "iceberg/util/formatter.h"  // IWYU pragma: keep
 
 namespace iceberg {
 

src/iceberg/schema_internal.cc

@@ -24,7 +24,6 @@
 #include <optional>
 #include <string>
 
-#include "iceberg/expected.h"
 #include "iceberg/schema.h"
 #include "iceberg/type.h"
 

src/iceberg/schema_internal.h

@@ -23,7 +23,6 @@
 
 #include <nanoarrow/nanoarrow.h>
 
-#include "iceberg/expected.h"
 #include "iceberg/result.h"
 #include "iceberg/type_fwd.h"
 

src/iceberg/sort_field.cc

@@ -22,8 +22,7 @@
 #include <format>
 
 #include "iceberg/transform.h"
-#include "iceberg/type.h"
-#include "iceberg/util/formatter.h"
+#include "iceberg/util/formatter.h"  // IWYU pragma: keep
 
 namespace iceberg {