Skip to content

Commit 5bf6c2b

Browse files
committed
fix: wrong error message
1 parent 03eb40b commit 5bf6c2b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/iceberg/sort_order.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Result<std::unique_ptr<SortOrder>> SortOrder::Make(const Schema& schema, int32_t
116116
for (const auto& field : fields) {
117117
ICEBERG_ASSIGN_OR_RAISE(auto schema_field, schema.FindFieldById(field.source_id()));
118118
if (schema_field == std::nullopt) {
119-
return InvalidArgument("Cannot find source column for sort field: {}", field);
119+
return InvalidArgument("Cannot find schema field for sort field: {}", field);
120120
}
121121

122122
const auto& source_type = schema_field.value().get().type();

src/iceberg/test/sort_order_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ TEST_F(SortOrderMakeTest, MakeInvalidSortOrderFieldNotInSchema) {
241241
auto sort_order = SortOrder::Make(
242242
*schema_, 1, std::vector<SortField>{*sort_field1_, sort_field_invalid});
243243
EXPECT_THAT(sort_order, IsError(ErrorKind::kInvalidArgument));
244-
EXPECT_THAT(sort_order, HasErrorMessage("Cannot find source column for sort field:"));
244+
EXPECT_THAT(sort_order, HasErrorMessage("Cannot find schema field for sort field"));
245245
}
246246

247247
TEST_F(SortOrderMakeTest, MakeUnboundSortOrder) {
@@ -254,7 +254,7 @@ TEST_F(SortOrderMakeTest, MakeUnboundSortOrder) {
254254
auto validate_status = sort_order.value()->Validate(*schema_);
255255
EXPECT_THAT(validate_status, IsError(ErrorKind::kInvalidArgument));
256256
EXPECT_THAT(validate_status,
257-
HasErrorMessage("Cannot find source column for sort field:"));
257+
HasErrorMessage("Cannot find schema field for sort field"));
258258
}
259259

260260
} // namespace iceberg

0 commit comments

Comments
 (0)