Skip to content

Commit 5ec5315

Browse files
author
xiao.dong
committed
migrate all java case
1 parent 28d9397 commit 5ec5315

File tree

2 files changed

+648
-85
lines changed

2 files changed

+648
-85
lines changed

src/iceberg/expression/inclusive_metrics_evaluator.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ class InclusiveMetricsVisitor : public BoundVisitor<bool> {
313313
return kRowsMightMatch;
314314
}
315315
const auto& lower = lower_result.value();
316-
auto lower_str = get<std::string>(lower.value());
316+
const auto& lower_str = get<std::string>(lower.value());
317317
// truncate lower bound so that its length in bytes is not greater than the length of
318318
// prefix
319319
int length = std::min(prefix.size(), lower_str.size());
@@ -327,7 +327,7 @@ class InclusiveMetricsVisitor : public BoundVisitor<bool> {
327327
return kRowsMightMatch;
328328
}
329329
const auto& upper = upper_result.value();
330-
auto upper_str = get<std::string>(upper.value());
330+
const auto& upper_str = get<std::string>(upper.value());
331331
// truncate upper bound so that its length in bytes is not greater than the length of
332332
// prefix
333333
length = std::min(prefix.size(), upper_str.size());
@@ -363,8 +363,8 @@ class InclusiveMetricsVisitor : public BoundVisitor<bool> {
363363
}
364364
const auto& lower = lower_result.value();
365365
const auto& upper = upper_result.value();
366-
auto lower_str = get<std::string>(lower.value());
367-
auto upper_str = get<std::string>(upper.value());
366+
const auto& lower_str = get<std::string>(lower.value());
367+
const auto& upper_str = get<std::string>(upper.value());
368368

369369
// if lower is shorter than the prefix then lower doesn't start with the prefix
370370
if (lower_str.size() < prefix.size()) {

0 commit comments

Comments
 (0)