Skip to content

Commit 657ba67

Browse files
author
xiao.dong
committed
fix todo
1 parent 0b17e28 commit 657ba67

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/iceberg/v1_metadata.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class ManifestEntryAdapterV1 : public ManifestEntryAdapter {
3232
public:
3333
ManifestEntryAdapterV1(std::optional<int64_t> snapshot_id,
3434
std::shared_ptr<Schema> schema) {
35-
// TODO: init v1 schema
35+
// TODO(xiao.dong): init v1 schema
3636
}
3737
Status StartAppending() override { return {}; }
3838
Status Append(const ManifestEntry& entry) override { return {}; }
@@ -48,7 +48,7 @@ class ManifestFileAdapterV1 : public ManifestFileAdapter {
4848
public:
4949
ManifestFileAdapterV1(int64_t snapshot_id, std::optional<int64_t> parent_snapshot_id,
5050
std::shared_ptr<Schema> schema) {
51-
// TODO: init v1 schema
51+
// TODO(xiao.dong): init v1 schema
5252
}
5353
Status StartAppending() override { return {}; }
5454
Status Append(const ManifestFile& file) override { return {}; }

src/iceberg/v2_metadata.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class ManifestEntryAdapterV2 : public ManifestEntryAdapter {
3232
public:
3333
ManifestEntryAdapterV2(std::optional<int64_t> snapshot_id,
3434
std::shared_ptr<Schema> schema) {
35-
// TODO: init v2 schema
35+
// TODO(xiao.dong): init v2 schema
3636
}
3737
Status StartAppending() override { return {}; }
3838
Status Append(const ManifestEntry& entry) override { return {}; }
@@ -48,7 +48,7 @@ class ManifestFileAdapterV2 : public ManifestFileAdapter {
4848
public:
4949
ManifestFileAdapterV2(int64_t snapshot_id, std::optional<int64_t> parent_snapshot_id,
5050
int64_t sequence_number, std::shared_ptr<Schema> schema) {
51-
// TODO: init v2 schema
51+
// TODO(xiao.dong): init v2 schema
5252
}
5353
Status StartAppending() override { return {}; }
5454
Status Append(const ManifestFile& file) override { return {}; }

src/iceberg/v3_metadata.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class ManifestEntryAdapterV3 : public ManifestEntryAdapter {
3333
ManifestEntryAdapterV3(std::optional<int64_t> snapshot_id,
3434
std::optional<int64_t> first_row_id,
3535
std::shared_ptr<Schema> schema) {
36-
// TODO: init v3 schema
36+
// TODO(xiao.dong): init v3 schema
3737
}
3838
Status StartAppending() override { return {}; }
3939
Status Append(const ManifestEntry& entry) override { return {}; }
@@ -50,7 +50,7 @@ class ManifestFileAdapterV3 : public ManifestFileAdapter {
5050
ManifestFileAdapterV3(int64_t snapshot_id, std::optional<int64_t> parent_snapshot_id,
5151
int64_t sequence_number, std::optional<int64_t> first_row_id,
5252
std::shared_ptr<Schema> schema) {
53-
// TODO: init v3 schema
53+
// TODO(xiao.dong): init v3 schema
5454
}
5555
Status StartAppending() override { return {}; }
5656
Status Append(const ManifestFile& file) override { return {}; }

src/iceberg/v4_metadata.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class ManifestEntryAdapterV4 : public ManifestEntryAdapter {
3333
ManifestEntryAdapterV4(std::optional<int64_t> snapshot_id,
3434
std::optional<int64_t> first_row_id,
3535
std::shared_ptr<Schema> schema) {
36-
// TODO: init v4 schema
36+
// TODO(xiao.dong): init v4 schema
3737
}
3838
Status StartAppending() override { return {}; }
3939
Status Append(const ManifestEntry& entry) override { return {}; }
@@ -50,7 +50,7 @@ class ManifestFileAdapterV4 : public ManifestFileAdapter {
5050
ManifestFileAdapterV4(int64_t snapshot_id, std::optional<int64_t> parent_snapshot_id,
5151
int64_t sequence_number, std::optional<int64_t> first_row_id,
5252
std::shared_ptr<Schema> schema) {
53-
// TODO: init v4 schema
53+
// TODO(xiao.dong): init v4 schema
5454
}
5555
Status StartAppending() override { return {}; }
5656
Status Append(const ManifestFile& file) override { return {}; }

0 commit comments

Comments
 (0)