feat: add table create/replace/update interface to catalog

Author: shuxu.li

src/iceberg/catalog.h

@@ -140,21 +140,6 @@ class ICEBERG_EXPORT Catalog {
       const std::string& location,
       const std::unordered_map<std::string, std::string>& properties) = 0;
 
-  /// \brief Start a transaction to replace a table
-  ///
-  /// \param identifier a table identifier
-  /// \param schema a schema
-  /// \param spec a partition spec
-  /// \param location a location for the table; leave empty if unspecified
-  /// \param properties a string map of table properties
-  /// \param orCreate whether to create the table if not exists
-  /// \return a Transaction to replace the table or ErrorKind::kNotFound if the table
-  /// doesn't exist and orCreate is false
-  virtual Result<std::shared_ptr<Transaction>> StageReplaceTable(
-      const TableIdentifier& identifier, const Schema& schema, const PartitionSpec& spec,
-      const std::string& location,
-      const std::unordered_map<std::string, std::string>& properties, bool orCreate) = 0;
-
   /// \brief Check whether table exists
   ///
   /// \param identifier a table identifier
@@ -247,16 +232,6 @@ class ICEBERG_EXPORT Catalog {
     ///
     /// \return the Transaction to create the table
     virtual std::unique_ptr<Transaction> StageCreate() = 0;
-
-    /// \brief Starts a transaction to replace the table
-    ///
-    /// \return the Transaction to replace the table
-    virtual std::unique_ptr<Transaction> StageReplace() = 0;
-
-    /// \brief Starts a transaction to create or replace the table
-    ///
-    /// \return the Transaction to create or replace the table
-    virtual std::unique_ptr<Transaction> StageCreateOrReplace() = 0;
   };
 
   /// \brief Instantiate a builder to either create a table or start a create/replace

src/iceberg/catalog/memory/in_memory_catalog.cc

@@ -404,13 +404,6 @@ Result<std::shared_ptr<Transaction>> InMemoryCatalog::StageCreateTable(
   return NotImplemented("stage create table");
 }
 
-Result<std::shared_ptr<Transaction>> InMemoryCatalog::StageReplaceTable(
-    const TableIdentifier& identifier, const Schema& schema, const PartitionSpec& spec,
-    const std::string& location,
-    const std::unordered_map<std::string, std::string>& properties, bool orCreate) {
-  return NotImplemented("stage replace table");
-}
-
 Result<bool> InMemoryCatalog::TableExists(const TableIdentifier& identifier) const {
   std::unique_lock lock(mutex_);
   return root_namespace_->TableExists(identifier);

src/iceberg/catalog/memory/in_memory_catalog.h

@@ -85,12 +85,6 @@ class ICEBERG_EXPORT InMemoryCatalog
       const std::string& location,
       const std::unordered_map<std::string, std::string>& properties) override;
 
-  Result<std::shared_ptr<Transaction>> StageReplaceTable(
-      const TableIdentifier& identifier, const Schema& schema, const PartitionSpec& spec,
-      const std::string& location,
-      const std::unordered_map<std::string, std::string>& properties,
-      bool orCreate) override;
-
   Result<bool> TableExists(const TableIdentifier& identifier) const override;
 
   Status DropTable(const TableIdentifier& identifier, bool purge) override;

src/iceberg/table.cc

@@ -133,7 +133,7 @@ const std::vector<SnapshotLogEntry>& Table::history() const {
   return metadata_->snapshot_log;
 }
 
-std::shared_ptr<Transaction> Table::NewTransaction() const {
+std::unique_ptr<Transaction> Table::NewTransaction() const {
   throw NotImplemented("Table::NewTransaction is not implemented");
 }
 

src/iceberg/table.h

@@ -112,7 +112,7 @@ class ICEBERG_EXPORT Table {
   /// \brief Create a new transaction for this table
   ///
   /// \return a shared pointer to the new Transaction
-  virtual std::shared_ptr<Transaction> NewTransaction() const;
+  virtual std::unique_ptr<Transaction> NewTransaction() const;
 
   /// \brief Returns a FileIO to read and write table data and metadata files
   const std::shared_ptr<FileIO>& io() const;

src/iceberg/test/mock_catalog.h

@@ -71,12 +71,6 @@ class MockCatalog : public Catalog {
                const std::string&, (const std::unordered_map<std::string, std::string>&)),
               (override));
 
-  MOCK_METHOD((Result<std::shared_ptr<Transaction>>), StageReplaceTable,
-              (const TableIdentifier&, const Schema&, const PartitionSpec&,
-               const std::string&, (const std::unordered_map<std::string, std::string>&),
-               bool),
-              (override));
-
   MOCK_METHOD(Result<bool>, TableExists, (const TableIdentifier&), (const, override));
 
   MOCK_METHOD(Status, DropTable, (const TableIdentifier&, bool), (override));

src/iceberg/transaction.h

@@ -51,7 +51,7 @@ class ICEBERG_EXPORT Transaction {
   /// \return Status::OK if all updates were queued successfully
   virtual Status UpdateTable(
       const std::vector<std::unique_ptr<TableRequirement>>& requirements,
-      std::vector<std::unique_ptr<TableUpdate>> updates) = 0;
+      const std::vector<std::unique_ptr<TableUpdate>>& updates) = 0;
 
   /// \brief Apply the pending changes from all actions and commit
   ///