fix date lib on Ubuntu CI

Author: wgtmac

.github/workflows/test.yml

@@ -52,7 +52,7 @@ jobs:
         shell: bash
         run: |
           sudo apt-get update
-          sudo apt-get install -y libdate-dev
+          sudo apt-get install -y libdate-tz3 libhowardhinnant-date-dev
       - name: Build Iceberg
         shell: bash
         run: ci/scripts/build_iceberg.sh $(pwd)

cmake_modules/IcebergThirdpartyToolchain.cmake

@@ -246,7 +246,8 @@ function(resolve_sparrow_dependency)
           ARCHIVE DESTINATION "${ICEBERG_INSTALL_LIBDIR}"
           LIBRARY DESTINATION "${ICEBERG_INSTALL_LIBDIR}")
 
-  # sparrow depends on date::date and date::date-tz
+  # sparrow depends on date::date and date::date-tz. It is tricky to use FetchContent
+  # to vendor date library since sparrow links date::date and date::date-tz directly.
   list(APPEND ICEBERG_SYSTEM_DEPENDENCIES date)
   set(ICEBERG_SYSTEM_DEPENDENCIES
       ${ICEBERG_SYSTEM_DEPENDENCIES}