Skip to content

Commit 6f6863d

Browse files
committed
fix: polish the tests
1 parent e576a53 commit 6f6863d

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/iceberg/test/json_internal_test.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ TEST(JsonInternalTest, SortOrder) {
110110
SortField st_ts(5, identity_transform, SortDirection::kAscending, NullOrder::kFirst);
111111
SortField st_bar(7, identity_transform, SortDirection::kDescending, NullOrder::kLast);
112112
ICEBERG_UNWRAP_OR_FAIL(auto sort_order, SortOrder::Make(100, {st_ts, st_bar}));
113+
EXPECT_TRUE(sort_order->Validate(*schema));
113114
nlohmann::json expected_sort_order =
114115
R"({"order-id":100,"fields":[
115116
{"transform":"identity","source-id":5,"direction":"asc","null-order":"nulls-first"},

src/iceberg/test/sort_order_test.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,10 +259,10 @@ TEST_F(SortOrderTest, MakeUnboundSortOrder) {
259259
SortField sort_field_invalid(999, Transform::Identity(), SortDirection::kAscending,
260260
NullOrder::kFirst);
261261

262-
auto sort_order =
263-
SortOrder::Make(1, std::vector<SortField>{*sort_field1_, sort_field_invalid});
264-
ASSERT_THAT(sort_order, IsOk());
265-
auto validate_status = sort_order.value()->Validate(*schema_);
262+
ICEBERG_UNWRAP_OR_FAIL(
263+
auto sort_order,
264+
SortOrder::Make(1, std::vector<SortField>{*sort_field1_, sort_field_invalid}));
265+
auto validate_status = sort_order->Validate(*schema_);
266266
EXPECT_THAT(validate_status, IsError(ErrorKind::kInvalidArgument));
267267
EXPECT_THAT(validate_status,
268268
HasErrorMessage("Cannot find source column for sort field"));

0 commit comments

Comments
 (0)