Skip to content

Commit 702d0f4

Browse files
committed
resolve comments
1 parent 3dc2b38 commit 702d0f4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/iceberg/table_scan.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ Result<std::unique_ptr<TableScan>> TableScanBuilder::Build() {
219219
}
220220
}
221221

222-
return std::make_unique<DataScan>(std::move(context_), file_io_);
222+
return std::make_unique<DataTableScan>(std::move(context_), file_io_);
223223
}
224224

225225
TableScan::TableScan(TableScanContext context, std::shared_ptr<FileIO> file_io)
@@ -235,10 +235,10 @@ const TableScanContext& TableScan::context() const { return context_; }
235235

236236
const std::shared_ptr<FileIO>& TableScan::io() const { return file_io_; }
237237

238-
DataScan::DataScan(TableScanContext context, std::shared_ptr<FileIO> file_io)
238+
DataTableScan::DataTableScan(TableScanContext context, std::shared_ptr<FileIO> file_io)
239239
: TableScan(std::move(context), std::move(file_io)) {}
240240

241-
Result<std::vector<std::shared_ptr<FileScanTask>>> DataScan::PlanFiles() const {
241+
Result<std::vector<std::shared_ptr<FileScanTask>>> DataTableScan::PlanFiles() const {
242242
ICEBERG_ASSIGN_OR_RAISE(auto manifest_list_reader,
243243
CreateManifestListReader(context_.snapshot->manifest_list));
244244
ICEBERG_ASSIGN_OR_RAISE(auto manifest_files, manifest_list_reader->Files());

src/iceberg/table_scan.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,10 @@ class ICEBERG_EXPORT TableScan {
187187
};
188188

189189
/// \brief A scan that reads data files and applies delete files to filter rows.
190-
class ICEBERG_EXPORT DataScan : public TableScan {
190+
class ICEBERG_EXPORT DataTableScan : public TableScan {
191191
public:
192192
/// \brief Constructs a DataScan with the given context and file I/O.
193-
DataScan(TableScanContext context, std::shared_ptr<FileIO> file_io);
193+
DataTableScan(TableScanContext context, std::shared_ptr<FileIO> file_io);
194194

195195
/// \brief Plans the scan tasks by resolving manifests and data files.
196196
/// \return A Result containing scan tasks or an error.

0 commit comments

Comments
 (0)