add test

Author: HeartLinked

test/manifest_reader_test.cc

@@ -131,7 +131,7 @@ class ManifestReaderV2Test : public TempFileTestBase {
     avro::RegisterLogicalTypes();
   }
 
-  std::vector<ManifestEntry> PrepareV2NonPartitionedManifestEntries() {
+  std::vector<ManifestEntry> prepareV2NonPartitionedManifestEntries() {
     std::vector<ManifestEntry> manifest_entries;
     std::string test_dir_prefix = "/tmp/db/db/v2_manifest_non_partitioned/data/";
 
@@ -180,14 +180,87 @@ class ManifestReaderV2Test : public TempFileTestBase {
     return manifest_entries;
   }
 
+  std::vector<ManifestEntry> prepareV2ManifestEntryMetadataInheritance() {
+    std::vector<ManifestEntry> manifest_entries;
+    std::string test_dir_prefix = "/tmp/db/db/v2_manifest_non_partitioned/data/";
+
+    std::vector<std::string> paths = {
+        "00000-0-b0f98903-6d21-45fd-9e0b-afbd4963e365-0-00001.parquet"};
+
+    std::vector<int64_t> file_sizes = {1344};
+    std::vector<int64_t> record_counts = {4};
+
+    std::vector<std::map<int32_t, std::vector<uint8_t>>> lower_bounds = {
+        {{1, {0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}},
+         {2, {'r', 'e', 'c', 'o', 'r', 'd', '_', 'f', 'o', 'u', 'r'}},
+         {3, {'d', 'a', 't', 'a', '_', 'c', 'o', 'n', 't', 'e', 'n', 't', '_', '1'}},
+         {4, {0xcd, 0xcc, 0xcc, 0xcc, 0xcc, 0xdc, 0x5e, 0x40}}}};
+
+    std::vector<std::map<int32_t, std::vector<uint8_t>>> upper_bounds = {
+        {{1, {0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}},
+         {2, {'r', 'e', 'c', 'o', 'r', 'd', '_', 't', 'w', 'o'}},
+         {3, {'d', 'a', 't', 'a', '_', 'c', 'o', 'n', 't', 'e', 'n', 't', '_', '4'}},
+         {4, {0x14, 0xae, 0x47, 0xe1, 0x7a, 0x8c, 0x7c, 0x40}}}};
+
+    manifest_entries.emplace_back(
+        ManifestEntry{.status = ManifestStatus::kAdded,
+                      .snapshot_id = 679879563479918846LL,
+                      .sequence_number = 15,
+                      .file_sequence_number = 15,
+                      .data_file = std::make_shared<DataFile>(
+                          DataFile{.file_path = test_dir_prefix + paths[0],
+                                   .file_format = FileFormatType::kParquet,
+                                   .record_count = record_counts[0],
+                                   .file_size_in_bytes = file_sizes[0],
+                                   .column_sizes = {{1, 56}, {2, 73}, {3, 66}, {4, 67}},
+                                   .value_counts = {{1, 4}, {2, 4}, {3, 4}, {4, 4}},
+                                   .null_value_counts = {{1, 0}, {2, 0}, {3, 0}, {4, 0}},
+                                   .nan_value_counts = {{4, 0}},
+                                   .lower_bounds = lower_bounds[0],
+                                   .upper_bounds = upper_bounds[0],
+                                   .key_metadata = {},
+                                   .split_offsets = {4},
+                                   .equality_ids = {},
+                                   .sort_order_id = 0,
+                                   .partition_spec_id = 12,  // inherit from manifest
+                                   .first_row_id = std::nullopt,
+                                   .referenced_data_file = std::nullopt,
+                                   .content_offset = std::nullopt,
+                                   .content_size_in_bytes = std::nullopt})});
+    return manifest_entries;
+  }
+
   std::shared_ptr<::arrow::fs::LocalFileSystem> local_fs_;
   std::shared_ptr<FileIO> file_io_;
 };
 
 TEST_F(ManifestReaderV2Test, V2NonPartitionedBasicTest) {
   std::string path = GetResourcePath("2ddf1bc9-830b-4015-aced-c060df36f150-m0.avro");
 
-  auto manifest_reader_result = ManifestReader::MakeReader(path, file_io_, nullptr);
+  auto manifest_reader_result = ManifestReader::Make(path, file_io_, nullptr);
+  ASSERT_EQ(manifest_reader_result.has_value(), true)
+      << manifest_reader_result.error().message;
+
+  auto manifest_reader = std::move(manifest_reader_result.value());
+  auto read_result = manifest_reader->Entries();
+  ASSERT_EQ(read_result.has_value(), true) << read_result.error().message;
+  ASSERT_EQ(read_result.value().size(), 1);
+
+  auto expected_entries = prepareV2NonPartitionedManifestEntries();
+  ASSERT_EQ(read_result.value(), expected_entries);
+}
+
+TEST_F(ManifestReaderV2Test, V2ManifestEntryMetadataInheritanceTest) {
+  std::string path = GetResourcePath("2ddf1bc9-830b-4015-aced-c060df36f150-m0.avro");
+  ManifestFile manifest_file{
+      .manifest_path = path,
+      .manifest_length = 100,
+      .partition_spec_id = 12,
+      .content = ManifestFile::Content::kData,
+      .sequence_number = 15,
+      .added_snapshot_id = 679879563479918846LL,
+  };
+  auto manifest_reader_result = ManifestReader::Make(manifest_file, file_io_, nullptr);
   ASSERT_EQ(manifest_reader_result.has_value(), true)
       << manifest_reader_result.error().message;
 
@@ -196,7 +269,7 @@ TEST_F(ManifestReaderV2Test, V2NonPartitionedBasicTest) {
   ASSERT_EQ(read_result.has_value(), true) << read_result.error().message;
   ASSERT_EQ(read_result.value().size(), 1);
 
-  auto expected_entries = PrepareV2NonPartitionedManifestEntries();
+  auto expected_entries = prepareV2ManifestEntryMetadataInheritance();
   ASSERT_EQ(read_result.value(), expected_entries);
 }