Skip to content

Commit 78d90b3

Browse files
author
xiao.dong
committed
fix comments
1 parent 16dbef9 commit 78d90b3

File tree

5 files changed

+6
-13
lines changed

5 files changed

+6
-13
lines changed

src/iceberg/manifest_adapter.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,12 @@
2323
/// Base class of adapter for v1v2v3v4 metadata.
2424

2525
#include "iceberg/arrow_c_data.h"
26-
#include "iceberg/manifest_entry.h"
27-
#include "iceberg/manifest_list.h"
2826
#include "iceberg/result.h"
27+
#include "iceberg/type_fwd.h"
2928

3029
namespace iceberg {
3130

32-
// \brief Base class of adapter for v1v2v3v4 metadata.
31+
// \brief Base class to append manifest metadata to Arrow array.
3332
class ICEBERG_EXPORT ManifestAdapter {
3433
public:
3534
ManifestAdapter() = default;

src/iceberg/manifest_writer.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ Status ManifestWriter::Close() {
5454
}
5555

5656
Result<std::unique_ptr<Writer>> OpenFileWriter(std::string_view location,
57-
const std::shared_ptr<Schema> schema,
57+
std::shared_ptr<Schema> schema,
5858
std::shared_ptr<FileIO> file_io) {
5959
ICEBERG_ASSIGN_OR_RAISE(
6060
auto writer,
61-
WriterFactoryRegistry::Open(
62-
FileFormatType::kAvro,
63-
{.path = std::string(location), .schema = schema, .io = std::move(file_io)}));
61+
WriterFactoryRegistry::Open(FileFormatType::kAvro, {.path = std::string(location),
62+
.schema = std::move(schema),
63+
.io = std::move(file_io)}));
6464
return writer;
6565
}
6666

src/iceberg/v1_metadata.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
/// \file iceberg/v1_metadata.h
2323

2424
#include "iceberg/manifest_adapter.h"
25-
#include "iceberg/manifest_entry.h"
26-
#include "iceberg/manifest_list.h"
2725

2826
namespace iceberg {
2927

src/iceberg/v2_metadata.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
/// \file iceberg/v2_metadata.h
2323

2424
#include "iceberg/manifest_adapter.h"
25-
#include "iceberg/manifest_entry.h"
26-
#include "iceberg/manifest_list.h"
2725

2826
namespace iceberg {
2927

src/iceberg/v3_metadata.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
/// \file iceberg/v3_metadata.h
2323

2424
#include "iceberg/manifest_adapter.h"
25-
#include "iceberg/manifest_entry.h"
26-
#include "iceberg/manifest_list.h"
2725

2826
namespace iceberg {
2927

0 commit comments

Comments
 (0)