Skip to content

Commit 79bba23

Browse files
committed
try to fix windows export
1 parent d88b5ee commit 79bba23

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

cmake_modules/BuildUtils.cmake

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,13 +215,18 @@ function(add_iceberg_lib LIB_NAME)
215215
string(TOUPPER ${LIB_NAME} LIB_NAME_UPPER)
216216
if(BUILD_SHARED)
217217
generate_export_header(${LIB_NAME}_shared BASE_NAME ${LIB_NAME_UPPER})
218-
target_compile_definitions(${LIB_NAME}_shared PRIVATE ${LIB_NAME}_EXPORTS)
218+
target_compile_definitions(${LIB_NAME}_shared
219+
PRIVATE ${LIB_NAME}_shared_EXPORTS
220+
PUBLIC ${LIB_NAME_UPPER}_STATIC_DEFINE)
219221
if(BUILD_STATIC)
220222
target_compile_definitions(${LIB_NAME}_static
221-
PRIVATE ${LIB_NAME_UPPER}_STATIC_DEFINE)
223+
PUBLIC ${LIB_NAME_UPPER}_STATIC_DEFINE)
222224
endif()
223225
elseif(BUILD_STATIC)
224226
generate_export_header(${LIB_NAME}_static BASE_NAME ${LIB_NAME_UPPER})
227+
target_compile_definitions(${LIB_NAME}_static
228+
PRIVATE ${LIB_NAME}_static_EXPORTS
229+
PUBLIC ${LIB_NAME_UPPER}_STATIC_DEFINE)
225230
endif()
226231

227232
# Modify variable in calling scope

0 commit comments

Comments
 (0)