File tree Expand file tree Collapse file tree 3 files changed +3
-5
lines changed
Expand file tree Collapse file tree 3 files changed +3
-5
lines changed Original file line number Diff line number Diff line change @@ -263,7 +263,7 @@ class ICEBERG_EXPORT BoundVisitor : public ExpressionVisitor<R> {
263263 // / Bound visitors do not support unbound predicates.
264264 // /
265265 // / \param pred The unbound predicate
266- Result<R> Predicate (const std::shared_ptr<UnboundPredicate>& pred) override {
266+ Result<R> Predicate (const std::shared_ptr<UnboundPredicate>& pred) final {
267267 ICEBERG_DCHECK (pred != nullptr , " UnboundPredicate cannot be null" );
268268 return NotSupported (" Not a bound predicate: {}" , pred->ToString ());
269269 }
Original file line number Diff line number Diff line change @@ -434,7 +434,7 @@ class InclusiveMetricsVisitor : public BoundVisitor<bool> {
434434 int id = ref.field ().field_id ();
435435 auto type = ref.type ();
436436 if (!type->is_primitive ()) {
437- return InvalidStats (" Lower bound of non-primitive type is not supported." );
437+ return Invalid (" Lower bound of non-primitive type is not supported." );
438438 }
439439 auto primitive_type = std::dynamic_pointer_cast<PrimitiveType>(type);
440440 if (!data_file_.lower_bounds .empty () && data_file_.lower_bounds .contains (id)) {
@@ -451,7 +451,7 @@ class InclusiveMetricsVisitor : public BoundVisitor<bool> {
451451 int id = ref.field ().field_id ();
452452 auto type = ref.type ();
453453 if (!type->is_primitive ()) {
454- return InvalidStats (" Upper bound of non-primitive type is not supported." );
454+ return Invalid (" Upper bound of non-primitive type is not supported." );
455455 }
456456 auto primitive_type = std::dynamic_pointer_cast<PrimitiveType>(type);
457457 if (!data_file_.upper_bounds .empty () && data_file_.upper_bounds .contains (id)) {
Original file line number Diff line number Diff line change @@ -43,7 +43,6 @@ enum class ErrorKind {
4343 kInvalidManifest ,
4444 kInvalidManifestList ,
4545 kInvalidSchema ,
46- kInvalidStats ,
4746 kIOError ,
4847 kJsonParseError ,
4948 kNamespaceNotEmpty ,
@@ -105,7 +104,6 @@ DEFINE_ERROR_FUNCTION(InvalidExpression)
105104DEFINE_ERROR_FUNCTION (InvalidManifest)
106105DEFINE_ERROR_FUNCTION (InvalidManifestList)
107106DEFINE_ERROR_FUNCTION (InvalidSchema)
108- DEFINE_ERROR_FUNCTION (InvalidStats)
109107DEFINE_ERROR_FUNCTION (IOError)
110108DEFINE_ERROR_FUNCTION (JsonParseError)
111109DEFINE_ERROR_FUNCTION (NamespaceNotEmpty)
You can’t perform that action at this time.
0 commit comments