Skip to content

Commit 7e08c33

Browse files
authored
ci: add clang-tidy (#32)
ci: add clang-tidy check This PR also changed cpp-linter's `tidy-checks` option to reduce misunderstanding, Rely on a .clang-tidy config file by specifying as a blank string (''), see [0] for details. [0] https://cpp-linter.github.io/cpp-linter-action/inputs-outputs/#tidy-checks --------- Signed-off-by: Junwang Zhao <[email protected]>
1 parent 47f636a commit 7e08c33

File tree

2 files changed

+38
-1
lines changed

2 files changed

+38
-1
lines changed

.clang-tidy

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# Licensed to the Apache Software Foundation (ASF) under one
2+
# or more contributor license agreements. See the NOTICE file
3+
# distributed with this work for additional information
4+
# regarding copyright ownership. The ASF licenses this file
5+
# to you under the Apache License, Version 2.0 (the
6+
# "License"); you may not use this file except in compliance
7+
# with the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing,
12+
# software distributed under the License is distributed on an
13+
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14+
# KIND, either express or implied. See the License for the
15+
# specific language governing permissions and limitations
16+
# under the License.
17+
---
18+
Checks: |
19+
-*,
20+
clang-diagnostic-*,
21+
clang-analyzer-*,
22+
google-*,
23+
modernize-*,
24+
-modernize-use-nodiscard,
25+
-modernize-use-trailing-return-type,
26+
27+
CheckOptions:
28+
- key: google-readability-braces-around-statements.ShortStatementLines
29+
value: '1'
30+
- key: google-readability-function-size.StatementThreshold
31+
value: '800'
32+
- key: google-readability-namespace-comments.ShortNamespaceLines
33+
value: '10'
34+
- key: google-readability-namespace-comments.SpacesBeforeComments
35+
value: '2'
36+
37+
HeaderFilterRegex: '(src|test|example)'

.github/workflows/cpp-linter.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4444
with:
4545
style: file
46-
tidy-checks: file
46+
tidy-checks: ''
4747
files-changed-only: true
4848
lines-changed-only: true
4949
thread-comments: true

0 commit comments

Comments
 (0)