Skip to content

Commit 7ef9cfe

Browse files
committed
Resolve aggregate rebase conflicts
2 parents dd5874b + d479ea5 commit 7ef9cfe

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

src/iceberg/expression/aggregate.cc

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,11 @@ Result<Literal> CountAggregate::Evaluate(const DataFile& file) const {
282282
return CountFor(file).transform(Literal::Long);
283283
}
284284

285+
Result<Literal> CountAggregate::Evaluate(const DataFile& file) const {
286+
ICEBERG_ASSIGN_OR_RAISE(auto count, CountFor(file));
287+
return Literal::Long(count);
288+
}
289+
285290
std::unique_ptr<BoundAggregate::Aggregator> CountAggregate::NewAggregator() const {
286291
return std::unique_ptr<BoundAggregate::Aggregator>(new CountAggregator(*this));
287292
}
@@ -526,7 +531,16 @@ class AggregateEvaluatorImpl : public AggregateEvaluator {
526531
}
527532

528533
bool AllAggregatorsValid() const override {
534+
<<<<<<< ours
529535
return std::ranges::all_of(aggregators_, &BoundAggregate::Aggregator::IsValid);
536+
=======
537+
for (const auto& aggregator : aggregators_) {
538+
if (!aggregator->IsValid()) {
539+
return false;
540+
}
541+
}
542+
return true;
543+
>>>>>>> theirs
530544
}
531545

532546
private:

0 commit comments

Comments
 (0)