feat: static table metadata access support

Author: shuxu.li

src/iceberg/table.h

@@ -20,6 +20,7 @@
 #pragma once
 
 #include <memory>
+#include <mutex>
 #include <string>
 #include <unordered_map>
 #include <vector>

test/CMakeLists.txt

@@ -46,10 +46,9 @@ add_test(NAME schema_test COMMAND schema_test)
 
 add_executable(table_test)
 target_include_directories(table_test PRIVATE "${CMAKE_BINARY_DIR}")
-target_sources(table_test PRIVATE table_test_helper.cc json_internal_test.cc table_test.cc
-                                  schema_json_test.cc)
-target_link_libraries(table_test PRIVATE iceberg_static GTest::gtest_main
-                                         GTest::gmock)
+target_sources(table_test PRIVATE table_test_helper.cc json_internal_test.cc
+                                  table_test.cc schema_json_test.cc)
+target_link_libraries(table_test PRIVATE iceberg_static GTest::gtest_main GTest::gmock)
 add_test(NAME table_test COMMAND table_test)
 
 add_executable(expression_test)
@@ -60,8 +59,8 @@ add_test(NAME expression_test COMMAND expression_test)
 
 add_executable(json_serde_test)
 target_include_directories(json_serde_test PRIVATE "${CMAKE_BINARY_DIR}")
-target_sources(json_serde_test PRIVATE table_test_helper.cc json_internal_test.cc metadata_serde_test.cc
-                                       schema_json_test.cc)
+target_sources(json_serde_test PRIVATE table_test_helper.cc json_internal_test.cc
+                                       metadata_serde_test.cc schema_json_test.cc)
 target_link_libraries(json_serde_test PRIVATE iceberg_static GTest::gtest_main
                                               GTest::gmock)
 add_test(NAME json_serde_test COMMAND json_serde_test)

test/table_test.cc

@@ -17,6 +17,8 @@
  * under the License.
  */
 
+#include "iceberg/table.h"
+
 #include <filesystem>
 #include <fstream>
 #include <optional>
@@ -30,7 +32,6 @@
 #include "iceberg/schema.h"
 #include "iceberg/snapshot.h"
 #include "iceberg/table_metadata.h"
-#include "iceberg/table.h"
 #include "table_test_helper.h"
 
 namespace iceberg {
@@ -46,7 +47,8 @@ class TableTest : public ::testing::Test {
 
 TEST_F(TableTest, TableSchemaV1Test) {
   std::unique_ptr<TableMetadata> metadata;
-  ASSERT_NO_FATAL_FAILURE(TableTestHelper::ReadTableMetadata("TableMetadataV1Valid.json", &metadata));
+  ASSERT_NO_FATAL_FAILURE(
+      TableTestHelper::ReadTableMetadata("TableMetadataV1Valid.json", &metadata));
 
   StaticTable table("test_table_v1", std::move(metadata));
   ASSERT_EQ(table.name(), "test_table_v1");
@@ -75,7 +77,8 @@ TEST_F(TableTest, TableSchemaV1Test) {
 
 TEST_F(TableTest, TableSchemaV2Test) {
   std::unique_ptr<TableMetadata> metadata;
-  ASSERT_NO_FATAL_FAILURE(TableTestHelper::ReadTableMetadata("TableMetadataV2Valid.json", &metadata));
+  ASSERT_NO_FATAL_FAILURE(
+      TableTestHelper::ReadTableMetadata("TableMetadataV2Valid.json", &metadata));
 
   StaticTable table("test_table_v2", std::move(metadata));
   ASSERT_EQ(table.name(), "test_table_v2");

test/table_test_helper.cc

@@ -1,5 +1,5 @@
 /*
-* Licensed to the Apache Software Foundation (ASF) under one
+ * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
  * distributed with this work for additional information
  * regarding copyright ownership.  The ASF licenses this file
@@ -19,6 +19,8 @@
 
 #pragma once
 
+#include "table_test_helper.h"
+
 #include <filesystem>
 #include <fstream>
 #include <optional>
@@ -30,35 +32,33 @@
 
 #include "iceberg/json_internal.h"
 #include "iceberg/test/test_config.h"
-#include "table_test_helper.h"
 
 namespace iceberg {
 
-  std::string TableTestHelper::GetResourcePath(const std::string& file_name) {
-    return std::string(ICEBERG_TEST_RESOURCES) + "/" + file_name;
-  }
+std::string TableTestHelper::GetResourcePath(const std::string& file_name) {
+  return std::string(ICEBERG_TEST_RESOURCES) + "/" + file_name;
+}
 
-  void TableTestHelper::ReadJsonFile(const std::string& file_name, std::string* content) {
-    std::filesystem::path path{GetResourcePath(file_name)};
-    ASSERT_TRUE(std::filesystem::exists(path))
-        << "File does not exist: " << path.string();
+void TableTestHelper::ReadJsonFile(const std::string& file_name, std::string* content) {
+  std::filesystem::path path{GetResourcePath(file_name)};
+  ASSERT_TRUE(std::filesystem::exists(path)) << "File does not exist: " << path.string();
 
-    std::ifstream file(path);
-    std::stringstream buffer;
-    buffer << file.rdbuf();
-    *content = buffer.str();
-  }
+  std::ifstream file(path);
+  std::stringstream buffer;
+  buffer << file.rdbuf();
+  *content = buffer.str();
+}
 
-  void TableTestHelper::ReadTableMetadata(const std::string& file_name,
-                                std::unique_ptr<TableMetadata>* metadata) {
-    std::string json_content;
-    ReadJsonFile(file_name, &json_content);
+void TableTestHelper::ReadTableMetadata(const std::string& file_name,
+                                        std::unique_ptr<TableMetadata>* metadata) {
+  std::string json_content;
+  ReadJsonFile(file_name, &json_content);
 
-    nlohmann::json json = nlohmann::json::parse(json_content);
-    auto result = TableMetadataFromJson(json);
-    ASSERT_TRUE(result.has_value()) << "Failed to parse table metadata from " << file_name
-                                    << ": " << result.error().message;
-    *metadata = std::move(result.value());
-  }
+  nlohmann::json json = nlohmann::json::parse(json_content);
+  auto result = TableMetadataFromJson(json);
+  ASSERT_TRUE(result.has_value()) << "Failed to parse table metadata from " << file_name
+                                  << ": " << result.error().message;
+  *metadata = std::move(result.value());
+}
 
-}  // namespace
+}  // namespace iceberg

test/table_test_helper.h

@@ -33,4 +33,4 @@ class TableTestHelper {
                                 std::unique_ptr<TableMetadata>* metadata);
 };
 
-}  // namespace iceberg
+}  // namespace iceberg