fix arrow uuid extension type

Author: wgtmac

src/iceberg/parquet/parquet_schema_util.cc

@@ -19,6 +19,7 @@
 
 #include <charconv>
 
+#include <arrow/extension_type.h>
 #include <arrow/type.h>
 #include <arrow/type_fwd.h>
 #include <arrow/util/key_value_metadata.h>
@@ -151,10 +152,10 @@ Status ValidateParquetSchemaEvolution(
       }
       break;
     case TypeId::kUuid:
-      if (arrow_type->id() == ::arrow::Type::FIXED_SIZE_BINARY) {
-        const auto& fixed_binary =
-            internal::checked_cast<const ::arrow::FixedSizeBinaryType&>(*arrow_type);
-        if (fixed_binary.byte_width() == 16) {
+      if (arrow_type->id() == ::arrow::Type::EXTENSION) {
+        const auto& extension_type =
+            internal::checked_cast<const ::arrow::ExtensionType&>(*arrow_type);
+        if (extension_type.extension_name() == "arrow.uuid") {
           return {};
         }
       }
@@ -213,7 +214,7 @@ Result<FieldProjection> ProjectStruct(
     if (!field_id) {
       continue;
     }
-    if (const auto [iter, inserted] = field_context_map.emplace(
+    if (const auto& [_, inserted] = field_context_map.emplace(
             std::piecewise_construct, std::forward_as_tuple(field_id.value()),
             std::forward_as_tuple(i, parquet_field));
         !inserted) [[unlikely]] {

test/parquet_schema_test.cc

@@ -110,10 +110,13 @@ ::parquet::arrow::SchemaManifest MakeSchemaManifest(
   auto parquet_schema_descriptor = std::make_shared<::parquet::SchemaDescriptor>();
   parquet_schema_descriptor->Init(parquet_schema);
 
+  auto properties = ::parquet::default_arrow_reader_properties();
+  properties.set_arrow_extensions_enabled(true);
+
   ::parquet::arrow::SchemaManifest manifest;
-  auto status = ::parquet::arrow::SchemaManifest::Make(
-      parquet_schema_descriptor.get(), /*key_value_metadata=*/nullptr,
-      ::parquet::default_arrow_reader_properties(), &manifest);
+  auto status = ::parquet::arrow::SchemaManifest::Make(parquet_schema_descriptor.get(),
+                                                       /*key_value_metadata=*/nullptr,
+                                                       properties, &manifest);
   if (!status.ok()) {
     throw std::runtime_error("Failed to create SchemaManifest: " + status.ToString());
   }