Skip to content

Commit 90cba7c

Browse files
committed
resole review comments
1 parent 0203492 commit 90cba7c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/iceberg/table_metadata.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ struct TableMetadataBuilder::Impl {
224224
explicit Impl(int8_t format_version) : base(nullptr), metadata{} {
225225
metadata.format_version = format_version;
226226
metadata.last_sequence_number = TableMetadata::kInitialSequenceNumber;
227-
metadata.last_updated_ms = TimePointMs::min();
227+
metadata.last_updated_ms = TableMetadata::kInvalidLastUpdatedMs;
228228
metadata.last_column_id = Schema::kInvalidColumnId;
229229
metadata.default_spec_id = PartitionSpec::kInitialSpecId;
230230
metadata.last_partition_id = PartitionSpec::kInvalidPartitionFieldId;
@@ -448,7 +448,7 @@ Result<std::unique_ptr<TableMetadata>> TableMetadataBuilder::Build() {
448448
// 2. Validate metadata consistency through TableMetadata#Validate
449449

450450
// 3. Update last_updated_ms if there are changes
451-
if (impl_->metadata.last_updated_ms == TimePointMs::min()) {
451+
if (impl_->metadata.last_updated_ms == TableMetadata::kInvalidLastUpdatedMs) {
452452
impl_->metadata.last_updated_ms =
453453
TimePointMs{std::chrono::duration_cast<std::chrono::milliseconds>(
454454
std::chrono::system_clock::now().time_since_epoch())};

src/iceberg/table_metadata.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ struct ICEBERG_EXPORT TableMetadata {
7373
static constexpr int64_t kInitialSequenceNumber = 0;
7474
static constexpr int64_t kInvalidSequenceNumber = -1;
7575
static constexpr int64_t kInitialRowId = 0;
76+
static constexpr TimePointMs kInvalidLastUpdatedMs = TimePointMs::min();
7677

7778
/// An integer version number for the format
7879
int8_t format_version;

0 commit comments

Comments
 (0)